GNOME Bugzilla – Bug 331509
Folder subscription : subscribe button is not enabled when i select a folder.
Last modified: 2013-09-13 00:50:56 UTC
The folder subscription dialog allows 2 ways of selecting a folder for subscribing. 1. by clicking on the check box and 2. by using the subscibe button. When I select (highlight) a folder, the subscribe button is not getting enabled, I have to enable the check box and say "Close" to subscribe. Once I enable a folder "Unsubscribe" button gets enabled and If I click on "Unsubscribe" button or un-check, then only "Subscribe" button gets enabled. So the first time it is confusing as there is no "OK" button, "Subscribe" button remains disabled, and user will not be sure if clicking on check box and closing will really subscribe or not.
Might require a UI change, so marked it for future.
In my view, it is not necessary to have the Subscribe and the Unsubscribe buttons at all. They confuse instead of clarifying. We can add a label saying that: "All folders checked will be marked for subscription" and have the close butotn alone. Same as the way in which the "Desktop background picture" applet works.
Both the buttons can be removed. Also than (tick) on a parent has to have some action. Target for future.
Created attachment 69457 [details] [review] Patch - removes the callback for buttons.
Created attachment 69458 [details] Glade file - after removing the buttons
Are you sure about the glade changes. It changes more than what it is supposed to do. The patch is OK otherwise except the right fmt of if/else may be reset by ur patch.
Created attachment 69459 [details] [review] Patch - diff for the glade file Above was the glade file itself. Here is the diff
committed to cvs head.