After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 331385 - [alpha] state change function returns a constant
[alpha] state change function returns a constant
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 0.10.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-16 07:56 UTC by Wouter Paesen
Modified: 2006-02-16 09:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Introduces the right behaviour (321 bytes, patch)
2006-02-16 07:57 UTC, Wouter Paesen 		committed Details | Review

Description Wouter Paesen 2006-02-16 07:56:30 UTC 
Please describe the problem:
GstAlpha's state_change function always returns GST_STATE_CHANGE_SUCCESS, no
matter if the state change function of the parent element succeeds or not.

I think it should just return the value of the parent elements state_change
function.  A patch will be uploaded that fixes this behaviour

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Wouter Paesen 2006-02-16 07:57:19 UTC 
Created attachment 59459 [details] [review]
Introduces the right behaviour
Comment 2 Tim-Philipp Müller 2006-02-16 09:23:16 UTC 
Applied (slightly modified), thanks!

2006-02-16  Tim-Philipp Müller  <tim at centricular dot net>

       * gst/alpha/gstalpha.c: (gst_alpha_change_state):
         Don't ignore return value of the parent class's state
         change function (#331385, patch by: Wouter Paesen).