After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 331344 - tile cache size in unsharp mask plugin
tile cache size in unsharp mask plugin
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Plugins
git master
Other Linux
: Normal minor
: 2.2
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2006-02-15 23:58 UTC by Stephane Chauveau
Modified: 2006-02-16 07:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to adapt the size of the cache to the max of both dimensions. (706 bytes, patch)
2006-02-16 00:00 UTC, Stephane Chauveau 		none Details | Review

Description Stephane Chauveau 2006-02-15 23:58:37 UTC 
In the unsharp mask plugin, the size of the tile cache is defined as

 2 * (drawable->width / gimp_tile_width () + 1 ) 

This is good for accessing the image horizontally but unsharp mask also applies a vertical blur for which that cache size is not always appropriate.  

For example, if unsharp mask is applied to a big image with a height larger than 2*width  (eg. 1000x3000), then the second third of the progress bar shows that the vertical blur is extremely slow.
Comment 1 Stephane Chauveau 2006-02-16 00:00:21 UTC 
Created attachment 59441 [details] [review]
Patch to adapt the size of the cache to the max of both dimensions.
Comment 2 Sven Neumann 2006-02-16 07:54:31 UTC 
Applied to both branches (with a minor adaption to the GIMP coding style). Thanks a lot.

2006-02-16  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/unsharp.c: applied patch from Stephane Chauveau
	that corrects the calculation of the tile cache size (bug #331344).