GNOME Bugzilla – Bug 331114
Tools dialog remove button a bit to small in dutch
Last modified: 2019-03-23 21:01:31 UTC
Please describe the problem: Well, first of all I don't really know if this is a bug in the glade file or not, but I'll report it anyway. In other languages than english the Remove label might be somewhat bigger rendering the text over the icon because the list has a fixed default width that is too small (http://www.icecrew.nl/~jesse/gedit/tools.png). Maybe the default width could be a bit larger? Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
nud: are you on it?
Created attachment 59960 [details] [review] Patch * plugins/externaltools/tools/tools.glade: fixed bug #331114 by removing all the size requests.
Created attachment 59966 [details] [review] fix + gsv + wrap As discussed on IRC, this patch solves the bug and make some small UI tweaks : - replace the command entry with a Sourceview (so, highlighting and ctrl+v) - add wrap to that entry
I am not sure using "bash" hl mode is a good idea. We could use bash by default and change it to python/perl/whatever if the user writes "#!/usr/bin/python" or similar strings at the beginning of the script.
I agree we should do without hl for now (hey there is always 2.16 :) Using sourceview though it's still a good idea in order to get undo/redo
I agree with the fact we should allow other languages than shell, but for now only bash commands work (I was in doubt and tested with a #! line but it does not work) so I don't see why highlighting is bad.
OK. Patch committed, though I dropped + view.set_auto_indent(True) + view.set_insert_spaces_instead_of_tabs(False) + view.set_smart_home_end(True) + view.set_tabs_width(4) better to use the default values if we don't watch GConf and gedit itself doesn't use smart_home_end. Beside 4-spaces-long tabs are the devil ;)