GNOME Bugzilla – Bug 331003
Don't bring up multiple authentication windows for same thing
Last modified: 2006-12-14 09:09:07 UTC
My music collection is placed on smb share, connection is added to nautilus. Opening it in nautilus makes no troubles, but when I try to run rhythmbox it spawns many windows with question about my keyring master password. ps -ux shows: fritz 28693 7.5 3.6 160480 19012 pts/2 Sl+ 16:33 0:01 rhythmbox fritz 28721 0.0 0.3 3848 1664 pts/3 Ss 16:33 0:00 zsh fritz 28736 4.6 1.5 13300 7984 tty1 S 16:33 0:00 /usr/lib/gnome-keyring-ask -k fritz 28738 4.5 1.5 13300 7984 tty1 S 16:33 0:00 /usr/lib/gnome-keyring-ask -k fritz 28741 4.6 1.5 13296 7980 tty1 S 16:33 0:00 /usr/lib/gnome-keyring-ask -k fritz 28743 4.0 1.5 13296 7984 tty1 S 16:33 0:00 /usr/lib/gnome-keyring-ask -k fritz 28747 4.6 1.5 13300 7984 tty1 S 16:33 0:00 /usr/lib/gnome-keyring-ask -k fritz 28749 4.6 1.5 13296 7984 tty1 S 16:33 0:00 /usr/lib/gnome-keyring-ask -k fritz 28751 4.6 1.5 13300 7984 tty1 S 16:33 0:00 /usr/lib/gnome-keyring-ask -k fritz 28753 4.4 1.5 13300 7980 tty1 S 16:33 0:00 /usr/lib/gnome-keyring-ask -k fritz 28755 4.5 1.5 13296 7980 tty1 S 16:33 0:00 /usr/lib/gnome-keyring-ask -k fritz 28757 4.6 1.5 13300 7984 tty1 S 16:33 0:00 /usr/lib/gnome-keyring-ask -k fritz 28761 2.4 1.5 13304 7896 tty1 S 16:33 0:00 /usr/lib/gnome-keyring-ask -k fritz 28763 0.0 0.1 2976 840 pts/3 R+ 16:33 0:00 ps ux
gnome-keyring shouldn't bring up multiple windows asking for authentication to the same thing, for the same application. Re-assigning to gnome-keyring.
I don't know how it can be a g-keyring problem. As I described above nautilus spawns only *one* window.
The only direct use Rhythmbox has is calling gnome_authentication_manager_init() at startup. A window should come up when gnome-vfs tried to access remote things that need authentication. I can't see how it would be anything other than a gnome-keying or gnome-vfs issue, but feel free for someone to reassign.
still present with g-k 0.4.8 :\
This is an issue that has been driving me nuts. Would really appreciate a fix.
Created attachment 66495 [details] [review] Proposed patch which fixes this This is a patch we're shipping in SUSE to fix this.
Hmm, ignore the gnome-keyring-ask part, that is a fix for another bug which is already checked into HEAD. Note that this patch only fixes the multiple windows in the case of asking for the master password, like you might see if you started up Gaim and NetworkManager at login, for example. It doesn't solve it for an application asking for the same resource multiple times, although this patch could probably be pretty easily adapted for that.
Ubuntu bug about that: https://launchpad.net/products/gnome-keyring/+bug/53967
That patch doesn't seem right. The use of timeouts is sort of ugly, and the timeout handler references other_ask, which might be destroyed (unless i missread the code). Also, i don't think you should ask again if the initial outstanding ask failed.
I commited a different approach that doesn't have the access-freed-memory issue. It also cheats by using a timeout though...