After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 330892 - config/Xession.in: failsafe session information text unreadable.
config/Xession.in: failsafe session information text unreadable.
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
2.13.x
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-12 15:04 UTC by Andreas Kohn
Modified: 2006-02-13 18:49 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14



Description Andreas Kohn 2006-02-12 15:04:16 UTC
Please describe the problem:
The failsafe Xsession shows a small zenity dialog, containing only the word "This".


Steps to reproduce:
run ${sysconfdir}/etc/gdm/Xsession failsafe, for example under Xnest.


Actual results:
Failsafe session comes up, but the information dialog (telling a user how to
QUIT the session) is unreadable.

Expected results:
the complete text in the dialog.

Does this happen every time?
yes.

Other information:
A patch to prevent the problem (it adds one level of quoting):
--------------
--- config/Xsession.in.orig     Tue Jul 19 09:53:41 2005
+++ config/Xsession.in  Sun Feb 12 13:34:34 2006
@@ -79,7 +79,7 @@

 if [ x"$command" = xfailsafe ] ; then
   if [ -n "$zenity" ] ; then
-    "$zenity" --info --text `gettextfunc "This is the failsafe xterm session.
Windows now have focus only if you have your cursor above them.  To get out of
this mode type 'exit' in the window in the upper left corner"`
+    "$zenity" --info --text "`gettextfunc "This is the failsafe xterm session.
 Windows now have focus only if you have your cursor above them.  To get out of
this mode type 'exit' in the window in the upper left corner"`"
   else
     echo "$0: Starting the failsafe xterm session."
   fi
@@ -239,7 +239,7 @@
 echo "$0: Executing $command failed, will run xterm"

 if [ -n "$zenity" ] ; then
-       "$zenity" --info --text `gettextfunc "Failed to start the session, so
starting a failsafe xterm session.  Windows will have focus only if the mouse
pointer is above them.  To get out of this mode type 'exit' in the window in the
upper left corner"`
+       "$zenity" --info --text "`gettextfunc "Failed to start the session, so
starting a failsafe xterm session.  Windows will have focus only if the mouse
pointer is above them.  To get out of this mode type 'exit' in the window in the
upper left corner"`"
 fi

 exec xterm -geometry 80x24+0+0
Comment 1 Brian Cameron 2006-02-13 18:49:34 UTC
Thanks for the report.  I see this problem too.  Your proposed fix didn't work on Solaris, so I fixed the problem by first setting a variable with the gettextfunc output and passing that into zenity, which makes the script a little easier to read I think and works on Solaris too.  This should fix the problem.