After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 330867 - Adding "License" button and dialog to About dialog
Adding "License" button and dialog to About dialog
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Rich Burridge
Rich Burridge
Depends on:
Blocks:
 
 
Reported: 2006-02-12 09:13 UTC by Behnam Esfahbod
Modified: 2006-03-28 17:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Desktop Applications - About dialogs (126.37 KB, image/jpeg)
2006-02-12 09:40 UTC, Behnam Esfahbod 		Details
Desktop Applications - About dialog (184.55 KB, image/jpeg)
2006-02-12 09:44 UTC, Behnam Esfahbod 		Details

Description Behnam Esfahbod 2006-02-12 09:13:43 UTC 
HIG says 
<http://developer.gnome.org/projects/gup/hig/2.0/menus-standard.html#menu-standard-help>:

"""Opens the About dialog for the application. Use the standard dialog provided by the GNOME libraries, which contains the name and version number of the application, a short description of the application's functionality, author contact details, copyright message and a pointer to the licence under which the application is made available."""

Gcalctool doesn't have the License button and license info.
Comment 1 Behnam Esfahbod 2006-02-12 09:40:19 UTC 
Created attachment 59170 [details]
Desktop Applications - About dialogs
Comment 2 Behnam Esfahbod 2006-02-12 09:44:24 UTC 
Created attachment 59171 [details]
Desktop Applications - About dialog
Comment 3 Rich Burridge 2006-02-12 16:14:08 UTC 
Looks like the majority of GNOME apps haven't added in the
Licence button yet.

As it's a UI change and we're frozen for them for GNOME 2.14,
I'll add it in for the next GNOME release.
Comment 4 Behnam Esfahbod 2006-02-13 11:27:26 UTC 
So the majority of GNOME desktop apps doesn't follow HIG.

Of course it's NOT a UI change, as the ui-freeze is just for generating documentations, which have nothing to do with the About dialog and License button.

Some other products accepted such report as a 2.14 blocker, so please accept it for 2.14.  I can give you the patch if you don't have time, etc.
Comment 5 Rich Burridge 2006-02-13 14:54:52 UTC 
Why don't you do right ahead and add that patch. 
Thankyou very much.
Comment 6 Rich Burridge 2006-03-28 17:32:24 UTC 
Fixed in CVS HEAD. Version number in configure.in
bumped to 5.8.3.