After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 330797 - spc enhancement to build outside source tree
spc enhancement to build outside source tree
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.8.11
Other Linux
: Normal normal
: 0.8.12
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-11 15:09 UTC by Bernard Leak
Modified: 2006-02-13 09:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
adds source dir to the search path for headers (1.03 KB, patch)
2006-02-11 15:12 UTC, Bernard Leak 		none Details | Review

Description Bernard Leak 2006-02-11 15:09:14 UTC 
*** PATCH KNOWN - WILL FOLLOW ***
Of all of the gst-plugins I can presently build (quite a few!), most are
quite happy building away from the source tree.  The exception is that the
NASM source files in <top>/ext/spc/ can't see their headers.
The obvious repair to Makefile.am doesn't work, but a bit of fiddling
and kicking the tyres got it working.

--
Bernard Leak
Comment 1 Bernard Leak 2006-02-11 15:12:25 UTC 
Created attachment 59140 [details] [review]
adds source dir to the search path for headers

NASM's handling of -I<path> is seriously stupid.  Hence the
bizarre trailing slash in '-I${srcdir)/' , which isn't optional!

This is a patch for the *release*, so it zaps Makefile.in as well
as Makefile.am .  You probably don't want the Makefile.in patch.
Comment 2 Andy Wingo 2006-02-13 09:57:04 UTC 
Thanks for the patch, but this appears to have been fixed previously by Ronald in preparation for the 0.8.12 release:

2006-02-06  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/libmms/gstmms.c: (gst_mms_srcpad_query), (gst_mms_get),
	(gst_mms_open), (gst_mms_close), (gst_mms_change_state),
	(gst_mms_uri_set_uri):
	* ext/libmms/gstmms.h:
	  Add support for mmsh:// style URIs.
	* ext/spc/Makefile.am:
	  Make ASM files compile with libtool (fixes warnings).

Happy hacking,

Andy.