GNOME Bugzilla – Bug 330577
[patch] add display options to advanced-portfolio report
Last modified: 2018-06-29 20:57:03 UTC
add display options to allow selection of columns to display in the advanced portfolio report. Allows user to select whether to display ticker symbol, exchange listing, number of shares and prices of shares. Also moved "share decimal places" to display options page as it seemed to make more sense there (IMHO). Couldn't figure out how to grey-out "share decimal places" when "show number of shares" is deselected... patch to follow A
Created attachment 59028 [details] [review] patch to add display options to advance-portfolio report
okay, so the "share decimal places" on the portfolio report is also on the general tab, should I move this one back for consistency? or does it matter? A
I'd suggest a "share decimal places" option belongs on a "Display" tab in the other report as well. As for "grey out": I don't think there is any easy way to achieve this in the current option system. Thanks for the patch.
(In reply to comment #3) > I'd suggest a "share decimal places" option belongs on a "Display" tab in the > other report as well. That would be the ONLY display tab option for the other report, but I'm happy to make that change. > > As for "grey out": I don't think there is any easy way to achieve this in the > current option system. It works in the transaction report with something*-callback-or-other* but I haven't looked into that beast yet. I was hoping someone would know it and pipe up. ;) > > Thanks for the patch. > :-) A
The grey-out is done via a complex-boolean-option and a callback using gnc:option-db-set-option-selectable-by-name -- take a look at the current fancy-invoice for hints. I've recently applied a number of changes to the advanced-portfolio so I suggest you rev the patch based on the current code, please?
well, that was fun. now attaching patch that includes a rework of this issue along with a fix of http://bugzilla.gnome.org/show_bug.cgi?id=314554 so that monster is now working as well. the newly attached patch does BOTH and assuming it all works as expected, both bugs could be closed. However, I don't work in multiple currencies so whether Mike's patch as fixed by me actually does what its supposed to do is unknown. it does however now run and gives expected results in my small set of test data. A
Created attachment 59380 [details] [review] reworked diffs for the previously submitted patch here it is...
Thanks. Applied (slightly fixed, per email to -devel) to SVN as r13264.
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=330577. Please update any external references or bookmarks.