After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 330083 - curves tool: damaged image when changing mode from RGB to grayscale
curves tool: damaged image when changing mode from RGB to grayscale
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Tools
2.2.x
Other All
: Normal normal
: 2.2
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2006-02-06 08:31 UTC by ManfredL
Modified: 2008-01-15 13:04 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description ManfredL 2006-02-06 08:31:12 UTC
I can reproduce the following effect with several images (scans from foto-negatives) in TIFF-format, 24BitsPerPixel and RGB-mode

-Open tools->colors->curves and change a curve (don't close the tool-window!)
-change image-mode from RGB to grayscale
-change again a curve
=> the image becomes a cubistic design, means there are a lot of squares in it

Opening the images brings up the message "unknown field with tag 317 (0x13d) encountered". Don't know, if it have context to the problem.

Got this on 2 different PC's, so I don't think it depends on hardware. The first time I tried it (on PC1), gimp crashes. But that was not reproducible.
OS: PC1->W2K with SP4. PC2->WinXP

Workaround: close curves-tool before changing the image-mode and re-open it after changing the mode
Comment 1 Sven Neumann 2006-02-06 11:32:11 UTC
The tool should be cancelled/reset on image mode changes.
Comment 2 Michael Natterer 2006-05-21 20:30:23 UTC
Fixed in HEAD:

2006-05-21  Michael Natterer  <mitch@gimp.org>

	* app/tools/tool_manager.c (tool_manager_image_clean_dirty): don't
	try to reset the active tool by destroying and re-creating it
	because this doesn't work while gimp->busy is TRUE. Call
	tool_manager_control_active(HALT) instead, which is the right way
	to do it anyway. Fixes bug #330083.

	Sprinkled some local variables all over the place to get rid of a
	gazillion tool_manager->active_tool.
Comment 3 Michael Natterer 2006-05-21 20:32:22 UTC
And in 2.2:

2006-05-21  Michael Natterer  <mitch@gimp.org>

	Merge from HEAD:

	* app/tools/tool_manager.c (tool_manager_image_clean_dirty): don't
	try to reset the active tool by destroying and re-creating it
	because this doesn't work while gimp->busy is TRUE. Call
	tool_manager_control_active(HALT) instead, which is the right way
	to do it anyway. Fixes bug #330083.