After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 329850 - io-svg.c won't compile as-is
io-svg.c won't compile as-is
Status: RESOLVED FIXED
Product: gdk-pixbuf
Classification: Platform
Component: general
git master
Other All
: High critical
: ---
Assigned To: gtk-bugs
gtk-bugs
: 335355 338022 340926 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-02-04 01:12 UTC by david gowers
Modified: 2010-07-10 04:06 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description david gowers 2006-02-04 01:12:18 UTC
Please describe the problem:
When trying to build (from CVS), I got the following warnings:

"
cc1: warnings being treated as errors
io-svg.c: In function 'fill_info':
io-svg.c:206: warning: pointer targets in initialization differ in signedness
io-svg.c:207: warning: pointer targets in initialization differ in signedness
io-svg.c:211: warning: pointer targets in initialization differ in signedness
io-svg.c:211: warning: pointer targets in initialization differ in signedness
io-svg.c:212: warning: pointer targets in initialization differ in signedness
io-svg.c:212: warning: pointer targets in initialization differ in signedness
"

which prevent compilation.
They are easily fixed by changing those 6 instances of (unsigned char *) to
(char *).

Steps to reproduce:
1. Try to compile from CVS with the gdk-pixbuf-loader enabled.


Actual results:


Expected results:
Success in compiling

Does this happen every time?
Yes

Other information:
Comment 1 Dominic Lachowicz 2006-02-04 02:53:44 UTC
What compiler and version of the compiler?
Comment 2 Dominic Lachowicz 2006-02-04 02:57:45 UTC
Reassigning to GTK+. According to their interface, they're supposed to be unsigned chars. Looking at the header file for GTK+ 2.9, they've changed them to chars, which constitutes an API breakage IMHO.

http://developer.gnome.org/doc/API/2.0/gdk-pixbuf/gdk-pixbuf-Module-Interface.html#GdkPixbufModulePattern
Comment 3 david gowers 2006-02-04 07:55:51 UTC
GCC.
gcc -v prints the following:
Using built-in specs.           
Target: i486-linux-gnu          
Configured with: ../src/configure -v --enable-languages=c,c++,java,f95,objc,ada,treelang --prefix=/usr --enable-shared --with-system-zlib --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --enable-nls --program-suffix=-4.0 --enable-__cxa_atexit --enable-clocale=gnu --enable-libstdcxx-debug --enable-java-awt=gtk-default --enable-gtk-cairo --with-java-home=/usr/lib/jvm/java-1.4.2-gcj-4.0-1.4.2.0/jre --enable-mpfr --disable-werror --with-tune=i686 --enable-checking=release i486-linux-gnu
Thread model: posix
gcc version 4.0.3 20060115 (prerelease) (Debian 4.0.2-7)

I suspect this is no longer relevant; included for completeness
Yes I'm using a recent CVS version of Gtk+
Comment 4 Dominic Lachowicz 2006-03-22 13:39:50 UTC
*** Bug 335355 has been marked as a duplicate of this bug. ***
Comment 5 Dominic Lachowicz 2006-04-10 20:36:08 UTC
*** Bug 338022 has been marked as a duplicate of this bug. ***
Comment 6 Dominic Lachowicz 2006-05-07 15:38:55 UTC
*** Bug 340926 has been marked as a duplicate of this bug. ***
Comment 7 Dominic Lachowicz 2006-05-07 15:51:00 UTC
I hacked librsvg so that it would compile with -Werror. -Werror considered harmful...

I guessed that this happens only in GTK+ >= 2.9.0, but it might be the case with 2.8.x too.
Comment 8 Javier Jardón (IRC: jjardon) 2009-11-11 05:07:00 UTC
This is not a problem anymore