After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 329161 - Some warnings in the build of gnome-terminal
Some warnings in the build of gnome-terminal
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
git master
Other Linux
: Normal trivial
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-01-30 04:11 UTC by Elijah Newren
Modified: 2006-01-30 04:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix the warnings (913 bytes, patch)
2006-01-30 04:13 UTC, Elijah Newren 		committed Details | Review

Description Elijah Newren 2006-01-30 04:11:48 UTC 
Due to bug 329159 (thanks for fixing it so fast!), I noticed a couple warnings and made a little patch to fix them.  The warnings were:

terminal-notebook.c: In function `close_button_clicked_cb':
terminal-notebook.c:725: warning: passing arg 1 of `gtk_widget_get_parent' from incompatible pointer type
terminal-notebook.c: In function `terminal_notebook_add_tab':
terminal-notebook.c:745: warning: assignment discards qualifiers from pointer target type

I'll attach a patch in a minute.
Comment 1 Elijah Newren 2006-01-30 04:13:14 UTC 
Created attachment 58369 [details] [review]
Fix the warnings
Comment 2 Guilherme de Siqueira Pastore 2006-01-30 04:16:56 UTC 
Regarding bug 329159, it was actually fixed already, it's just that I committed the fix when you reported the bug. That's why I looked so fast ;) Thanks for being so fast at reporting it =)

Now back to this one, I've applied the patch. Thanks!