GNOME Bugzilla – Bug 328949
Hiding/Showing through tray icon suboptimal
Last modified: 2006-06-03 20:04:56 UTC
Currently, when clicking the tray icon, the following happens: private void OnTrayClick(object o, EventArgs args) { WindowPlayer.Visible = !WindowPlayer.Visible; ResizeMoveWindow(); } This behavior is fine, but could use some improvements: * If banshee is visible, but not on the currently visible desktop, don't hide it, instead show it on the currently visible desktop. * If banshee is minimized, don't hide, yet unminimize. * If banshee is hidden behind other windows, don't hide, but bring it to the front. The tray icon behavior would then be the expected "If I see banshee and I click on it, hide it! If I don't see banshee and I click on it, show it!". Currently the only application that does this right (as far as I know) is gaim, the code for this is here: http://cvs.sourceforge.net/viewcvs.py/gaim/gaim/plugins/docklet/ Will look into this someday in the future (when time permits it), marking it as a gnome-love task for now. If someone is willing to look into this, please do!
Moving to the Plugins component. Now relates to the notification area plugin.
Created attachment 63922 [details] [review] Proposed patch
Excellent patch, I like it.
I second the excellentness :) Will be committed in my next round.