GNOME Bugzilla – Bug 328102
Clairfy what page the toolbar page number applies to.
Last modified: 2006-02-24 19:14:35 UTC
When (parts of) multiple pages are visible, it is not immediately obvious which of those pages the page number in the tool bar relates to. It would be nice if there was some visible indication, e.g., an emphasized border around the current page. [The side-bar does have some indication, but (a) the side-bar might be closed, or (b) there might not be enough visual distinction between thumbnails, especially for a poorly sighted user]. Additionally, when scrolling through a document, the page number does not change until the very last pixel of the selected page disappears. It would be more intuitive if e.g., the page with the largest area displayed was the current page. Other information:
Fully agree
Created attachment 59897 [details] [review] Add smart current-page selection and highlite current page 2006-02-21 Ricardo F. Markiewicz <rmarkie@fi.uba.ar> * backend/ev-document-misc.c: * backend/ev-document-misc.h: (ev_document_misc_paint_one_page) * shell/ev-view.c: (draw_one_page), (ev_view_expose_event): Clairfy what page the toolbar page number applies to, changing the border color. * shell/ev-view.c: (view_update_range_and_current_page), (draw_one_page), (ev_view_size_allocate), (ev_view_expose_event), (page_changed_cb), (on_adjustment_value_changed): Smart current-page selection, based on the visible area of visible's pages. Fix for the bug #328102.
The attached patch is my intent to close this bugs. Some comments : a) I'm unsure of what GC use to highlite the border of current page. b) The smart current-page selection does not convince me. I spent a week trying this work properly. The problem is that update_range_and_current_page is called always when ev_page_cache emit PAGE_CHANGED signal. Sometimes you can't select (clicking in the thumbails for example) a visible page with smaller visible area that current, so I added the set_best_current_page boolean to avoid use this method in some circustancies. Tell me what you think
Thanks Ricardo, really cool patch. Let's separate the issues though, we discuss the problem with current page selection in bug 312573. Can you split the patch on two parts, one for this bug and one for the bug 312573. And, please use English "highlight"
> Let's separate the issues though, we discuss the problem with current page > selection in bug 312573 My Bad, I didn't see that bug. I'll split the patch this night. > And, please use English "highlight" Ups :)
Surely not, I also forgot about that. About this partucular problem. For me it seems rather strange that current page is gray while others are black. Probably we should use opposite colors - gray for all, black for current. Or black for all, selection color for current. Can you please attach also the screenshot of patched evince where changes are visually clear, we will ask Bryan about new look.
Created attachment 59967 [details] Current page gray
Created attachment 59968 [details] Current page black
Done. Tell me what version of the patch do you prefer
I think we could use the black for the current and gray for the others, not just for the document view, but also for thumbnails.
I also like black on grey more, part of patch is committe, thanks a lot Ricardo.