GNOME Bugzilla – Bug 327754
run dialog(alt-f2) is giving non-usable error message
Last modified: 2006-11-15 11:56:52 UTC
This bug has been described on https://launchpad.net/distros/ubuntu/+source/gnome-panel/+bug/29005 "When entering a non-existant command into the run dialog and pressing enter, the error message Could not open location 'file://asd' Details: Unknown error code: 13 Pops up - that's rather cryptic and non-informative for a random user. I would expect either a shaking window like in gnome-screensaver or a more useful message."
This is actually a libgnome bug. gnome_url_show_with_env () doesn't recognize the GNOME_VFS_ERROR_INVALID_URI error and therefore sends the default message to the panel. Reassigning to libgnome.
Created attachment 57971 [details] [review] handle GNOME_VFS_ERROR_INVALID_URI error The message could not be the best, but you get the idea.
Cool (I'm always happy to see bugs move away from gnome-panel). Anyone to review the patch? :-) This is a new string so we have to add it soon.
Adding string keyword, hopefully someone will interest on it.
*** Bug 330306 has been marked as a duplicate of this bug. ***
Ok to commit? String freeze is getting closer and closer!
I agree that this issue has to be tackled, but aren't we opening a can of worms here? gnome_url_show_with_env is just a wrapper around gnome_vfs_url_show_with_env converting its results into a retval and a g_set_error, and the last few commits all deal with missing retvals. We'd just reach partity if the error enum matches GnomeVFSResult. We could deprecate gnome_vfs_url_show_with_env and directly call the gnome-vfs helper.
Christian: the error strings are more explicit in libgnome than in gnome-vfs, though.
Vincent: Maybe we need helpers for getting more explicit strings from gnome-vfs which are ready to be displayed to the user? Kjartan, are you OK with this patch?
Looks good to me, but we're breaking the freeze now I guess?
String freeze starts tomorrow :-) Claudio: if you have a cvs account, I guess this means "go go go".
Vincent, I can commit before the string freeze, that is not a problem :-) I would love to hear suggestions for the string. I am not sure if "The location or file could not be found." is good enough. What do you think? I will commit it before the string freeze if nobody suggest something better.
Fixed. Am about to mail everyone. 2006-02-12 Claudio Saavedra <csaavedra@alumnos.utalca.cl> * libgnome/gnome-url.c: (gnome_url_show_with_env): Add handling of GNOME_VFS_ERROR_INVALID_URI error and a user readable message (Fixes #327754).
Still happening, reopening. the call returns an GNOME_VFS_ERROR_NOT_FOUND not a GNOME_VFS_ERROR_INVALID_URI and anyway the dialog is to run an application, so the message should be than the command is not found and not that the location is incorrect
(In reply to comment #14) > Still happening, reopening. the call returns an GNOME_VFS_ERROR_NOT_FOUND not a > GNOME_VFS_ERROR_INVALID_URI Which command you entered to get a GNOME_VFS_ERROR_NOT_FOUND? I still get the GNOME_VFS_ERROR_INVALID_URI. > and anyway the dialog is to run an application, so > the message should be than the command is not found and not that the location > is incorrect > When entering a filename (and not an application) in the dialog this opens it with the default associated application. I agree that probably that is not what the dialog is intended for, but it is the way it is currently working. Maybe the dialog should autocomplete only executable files in the path and not everything that matches in $HOME.
I can get different 'unknown error code' messages by typing the protocol in the run dialogue, Try the following ones ftp://ftp.gnome.org sftp://gnome.org /home/foo
I don't see this any more. ftp:// and sftp:// opens nautilus correctly and /home/foo just says that it can't open it because it doesn't exist. An existing folder will open just fine with no error message. Please reopen if you can still reproduce this somehow.