After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 327061 - Empty artist remains in browser until rb restart
Empty artist remains in browser until rb restart
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: User Interface
0.9.x
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 323086 329288 329290 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-01-15 12:36 UTC by Baptiste Mille-Mathias
Modified: 2006-01-31 15:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
partial patch (3.70 KB, patch)
2006-01-31 05:41 UTC, James "Doc" Livingston 		none Details | Review
updated patch (7.12 KB, patch)
2006-01-31 12:06 UTC, James "Doc" Livingston 		committed Details | Review

Description Baptiste Mille-Mathias 2006-01-15 12:36:05 UTC 
Test case:
1/ browse and select an artist
2/ select all the songs of this artist
3/ delete the songs of this artist.

Result
4/ the artist is still present in the browser. Need to restart RB to make it disappear.
Comment 1 Hidde Brugmans 2006-01-16 02:56:02 UTC 
The same goes for Genre.
Comment 2 James "Doc" Livingston 2006-01-31 04:14:34 UTC 
*** Bug 329288 has been marked as a duplicate of this bug. ***
Comment 3 James "Doc" Livingston 2006-01-31 04:51:42 UTC 
*** Bug 329290 has been marked as a duplicate of this bug. ***
Comment 4 James "Doc" Livingston 2006-01-31 05:34:15 UTC 
*** Bug 323086 has been marked as a duplicate of this bug. ***
Comment 5 James "Doc" Livingston 2006-01-31 05:41:27 UTC 
Created attachment 58443 [details] [review]
partial patch

This fixed part of the problem, that property models weren't updating when an entry changed it's visibility. This makes it work correctly if the browsers are set on All.

There seems to be a second issue, that when browsers have things (other than All) selected, they aren't receiving change notification from their query models. I'm not sure why.
Comment 6 Jonathan Matthew 2006-01-31 09:12:09 UTC 
When the active query model on a RBEntryView is changed, it calls rhythmdb_query_model_set_connected (FALSE) on the old one, which causes it to ignore entry change events.  I'm not really sure why this is, and I don't think anything bad would happen if we removed the notion of query models being 'connected'.

I made a change in the iradio source a while ago to keep the 'all' query model connected, for the same reason - so that the iradio genre list would be updated correctly when stations were modified or removed.
Comment 7 James "Doc" Livingston 2006-01-31 12:06:25 UTC 
Created attachment 58462 [details] [review]
updated patch

This removed the "connected" property of query models, which fixes the remaining issue.
Comment 8 James "Doc" Livingston 2006-01-31 15:59:05 UTC 
Patch committed to cvs. This fixes the problems for me.