GNOME Bugzilla – Bug 326646
Unnecessary markup inside translatable messages (non-Glade)
Last modified: 2006-01-13 08:50:41 UTC
You're quite good in hiding markup from translators. Thanks for that. But you've missed some messages. Affected source files: - gedit/gedit-io-error-message-area.c - gedit/gedit-tag.c - gedit/gedit-utils.c Patch follows soon. Please review it carefully. It will be untested and written by a C no-op... ;) Would be nice to get this fixed before string freeze.
Created attachment 57186 [details] [review] Patch to remove embedded markup from various messages I've done a build of a 2.13.1 RPM with this patch. Worked. Triggerd some messages, but could not issue all of them. Another problem I've found: In gedit-tab.c around line 600 you will find the following: if (to != NULL) { ... } else { msg = g_markup_printf_escaped (_("Saving <b>%s</b>", to); } "to" is always NULL here. I've already changed this within this patch. It's replaced with "from".
Thanks, the patch looks quite good to me and you are right about s/to/from The only issue I noticed is in the spots where you do + gchar *host_name = g_strdup_printf ("<i>%s</i>", + gedit_utils_make_valid_utf8 (hn)); This leaks the result of gedit_utils_make_valid_utf8. Gotta love C string handling ;)
Created attachment 57233 [details] [review] Modified patch This one should do it better...
Comment on attachment 57233 [details] [review] Modified patch Please, add /* Translators: %s is a URI scheme (like for example http, ftp, etc.) */ before the followinging line in gedit_unrecoverable_reverting_error_message: If you find other missing comments for translators please feel free to add them. Please, commit with a ChangeLog entry and send an email to gnome-i18n list announcing the string changes.
Ok, took some hours. I had to earn money in the meantime. I've found another glitch myself. In gedit_unrecoverable_saving_error_message I missed to change scheme_string to scheme_markup. Additionally appended a colon to example locations inside translator comments and added the missing one. - Again slightly modified patch was committed right now - Mail to gnome-i18n was sent - Bug is fixed... :)