GNOME Bugzilla – Bug 326284
Code cleanups for Evolution
Last modified: 2013-09-13 01:00:29 UTC
Attaching a series of patches with code cleanups of various sorts: - remove unused vars - remove extraneous semi-colons - add some comments where assignments were done without using the results later - remove break; statements after return foo; - add casts in some places to be more type correct - rename variables with name clashes - s/if/ifdef in some cases - mark some code static - remove some unused functions - use guint for 1-bit bitfields
Created attachment 57014 [details] [review] a11y cleanups
Created attachment 57015 [details] [review] addressbook cleanups
Created attachment 57016 [details] [review] calendar cleanups
Created attachment 57017 [details] [review] composer cleanups
Created attachment 57018 [details] [review] e-util cleanups
Created attachment 57019 [details] [review] filter cleanups
Created attachment 57020 [details] [review] mail cleanups
Created attachment 57021 [details] [review] plugins cleanups
Created attachment 57022 [details] [review] shell cleanups
Created attachment 57023 [details] [review] smime-cleanups
Created attachment 57024 [details] [review] tools cleanups
Created attachment 57025 [details] [review] widgets cleanups
*** Bug 323451 has been marked as a duplicate of this bug. ***
very cool. evo-hackers/harish: when reviewing this, please also take a look at other code cleanup stuff by ross: http://bugzilla.gnome.org/buglist.cgi?short_desc_type=allwordssubstr&short_desc=&product=Evolution&product=Evolution-Data-Server&long_desc_type=allwordssubstr&long_desc=&status_whiteboard_type=allwordssubstr&status_whiteboard=&keywords_type=anywords&keywords=perf%2C+memory&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&emailreporter1=1&emailtype1=substring&email1=ross%40burtonini.com&emailtype2=substring&email2=&bugidtype=include&bug_id=&changedin=&chfieldfrom=&chfieldto=Now&chfieldvalue=&cmdtype=doit&newqueryname=&order=Reuse+same+sort+as+last+time&field0-0-0=noop&type0-0-0=noop&value0-0-0= thanks in advance.
Reviewing all these patches and targeting them for 2.14.0 Beta.
I think some of them needs updating because they overlap with fixes that have gone in already. I'll see if I can do that soon
Thanks. I hope you would not mind if I make those changes wherever necessary and absorb them - so they get into 2.14.0 Beta.
Commited the two first ones after fixing some conflicts.
I commited the plugin stuff by accident when cleaning up .cvsignore in that dir. Please tell me if I should revert all of it or parts of it and I'll do that asap.
Not all warnings have been fixed by these patches. However, let us get the available fixes in. On plugins, I shall review and undo the changes, if necessary. (by far, I assume most are harmless).
Ok, Commited the ones you've looked at. I reverted some of the changes where it was unclear whether the fix was right or not, but that's a total of two or three minor changes.
harish, are you also going to review kjartan's code cleanups for gtkhtml (bug 323450)?
Commiting and closing. Thanks a lot.