GNOME Bugzilla – Bug 326199
EOG should warn the user if the opened directory doesn't contain images
Last modified: 2007-02-26 22:57:20 UTC
Please describe the problem: When starting eog like this... $ eog /some/path/to/an/images/dir ... eog is started, but shows nothing (a very small eog window appears). Of course a user would expect a directory/collection view to be opened for the specified path. Steps to reproduce: 1. Open a terminal 2. Start eog and specify a directory containing images Actual results: EOG starts in no-file mode (in a tiny window) Expected results: A directory/collection view appears Does this happen every time? yes Other information:
Hmmm. I mistyped the dirname (forgot one trailing path component). That directory did not contain any images. Still I think a tiny, empty eog window is not friendly.
What do you think would be more friendly? A warning dialog?
A warning dialog is an option, but I can also image a less intrusive way of telling the user there are no files in the current directory. What about showing a text like "No images at the current location" in the image panel? Btw, are there any plans on a directory browser? (Eg. showing directory names and the ".." directory in the thumbnail bar?).
I think you got to show some comment or it looks silly, for most users, wondering whats wrong! I mean users arent so intelligent, or care about whats going on and why, they want it right. I agree with Wouter Bolsterlee's second post.
Is this bug still valid or it turned to an enhancement request? I am having an issue with EOG in HEAD, it seems to be ignoring the files/directories given as a command line parameter and opening only a empty window. Can somebody confirm it please?
This bug is still valid. Eog correctly shows the directory if there are any images in it, but if the directory does not contain images the screen is just plain boring grey without telling me what's happening :)
Changing summary and severity to enhancement.
Fixed in eog-ng. Closing as there are no plans to fix this in trunk. 2007-02-26 Lucas Rocha <lucasr@gnome.org> Messages for the most of common error: open a set of locations with no images, open a directory with no images, open a non-image file and open a corrupted/invalid image. Fixes bugs #326199, #399988, and #316175. * src/eog-list-store.c (eog_list_store_add_uris, eog_list_store_class_init, eog_list_store_init): add initial image even if it doesn't pass the mimetype tests. GObject love and code cleanups. * src/eog-application.c: comment unused function to fix build warning. * src/eog-window.c (eog_job_load_cb, eog_window_open_uri_list, eog_window_dispose, eog_job_model_cb): set window title with image caption even in image loading error cases. Set error message area when no images are found in given locations. * src/eog-error-message-area.[ch] (eog_no_images_error_message_area_new): new message area for errors when no images are found in given locations.