GNOME Bugzilla – Bug 325882
[KB-Fixed] Enforce send/receive mail dialog window position
Last modified: 2009-08-30 05:53:38 UTC
Neither the password query nor the send/receive mail dialog set position hints. Thus, Metacity often puts them in random positions. Calling gtk_window_set_transient_for (dialog, window); gtk_window_set_position (dialog, GTK_WIN_POS_CENTER_ON_PARENT); before the dialog is mapped should be enough. Maybe sb. should go through all the dialogs and check whether they have position hints set.
Won't do it changing this lines?: i.e. in mail-dialogs.glade: <property name="window_position">GTK_WIN_POS_NONE</property> to <property name="window_position">GTK_WIN_POS_CENTER_ON_PARENT</property> instead of gtk_window_set*, I mean.
srini, a nosip task i guess?
*** Bug 339783 has been marked as a duplicate of this bug. ***
Created attachment 89766 [details] [review] proposed patch for evolution; I changed GTK_WIN_POS_NONE to GTK_WIN_POS_CENTER_ON_PARENT but only there, where was no "gravity" property.
The patch looks fine. But Im not sure, if we need to patch designs/. It is not compiled and it was for design/discussion and I don't know much about it. I don't think this fixes either password or send/receive. But a good amount of dialogs look neat.
Committed.
Bumping version to a stable release.
Created attachment 110168 [details] [review] e-passwords.c Here's a patch for the password dialog. It relies on the caller to provide the parent window, which Evolution can't always do. (Note, passing a NULL parent to gtk_window_set_transient_for() is acceptable.) This is more difficult for the Send/Receive dialog because the mail component doesn't have easy access to the main (parent) window, thanks to Bonobo. In fact this is the case for many dialogs in Evolution.
COmmit to stable/trunk
Committed to trunk (revision 8736) and gnome-2-22 (revision 8737). Adjusting summary for the remaining issue and leaving open until we give Bonobo the boot, or find a workaround.
Fixed now on the kill-bonobo branch.
The "kill-bonobo" branch has been merged into "master" and will debut as Evolution 2.29.1. We believe the branch has addressed the reported issue. If you find the issue still exists in version 2.29 or later please feel free to re-open this bug. Closing as FIXED.