After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 325745 - White, black, grey point selection buttons have no text or icons in the levels dialog
White, black, grey point selection buttons have no text or icons in the level...
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: User Interface
2.3.x
Other Windows
: Normal minor
: 2.2
Assigned To: GIMP Bugs
GIMP Bugs
: 330421 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-01-04 09:57 UTC by Alexander Rabtchevich
Modified: 2008-01-15 14:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
the screenshot of levels dialog (11.01 KB, image/png)
2006-01-04 09:58 UTC, Alexander Rabtchevich
Details

Description Alexander Rabtchevich 2006-01-04 09:57:09 UTC
Please describe the problem:
The grey selection and simular buttons is too small and has no text nor icon.
The application uses the default scheme.

Steps to reproduce:
1. Open levels buttons.
2. See the small buttons.


Actual results:


Expected results:


Does this happen every time?
Yes.

Other information:
Maybe it's a Win32 specific issue, I don't know.
Comment 1 Alexander Rabtchevich 2006-01-04 09:58:54 UTC
Created attachment 56755 [details]
the screenshot of levels dialog

Look at the colour selection buttons
Comment 2 Sven Neumann 2006-01-04 13:20:17 UTC
Looks like a problem with your build. But since 2.3.5 is a development version and not even the latest released one, it is probably not worth investigating this further. Closing as OBSOLETE.
Comment 3 Lex Mulcahy 2006-01-05 09:35:43 UTC
(In reply to comment #2)
> Looks like a problem with your build. But since 2.3.5 is a development version
> and not even the latest released one, it is probably not worth investigating
> this further. Closing as OBSOLETE.

This bug also occurs in the Windows build of version 2.2.10 and is worth investigating further!
Comment 4 Michael Schumacher 2006-01-05 11:10:14 UTC
Yep, reopening.
Comment 5 Michael Natterer 2006-01-05 11:14:40 UTC
Michael, since you see this too, would you mind adding some
debugging printf to gimp_enum_stock_box_new_with_range() in
libgimpwidgets/gimpenumwidgets.c ?

The critical part being the call to gtk_image_new_from_stock()
Comment 6 Michael Schumacher 2006-01-12 18:46:48 UTC
I can't reproduce this in my own builds (gimp-2-2 and HEAD). Maybe it is a problem  with the binaries in the installers?
Comment 7 Jernej Simončič 2006-01-12 19:36:57 UTC
I know what the problem is: GTK+ on Windows by default ships with disabled images on buttons - the gtkrc for the ms-windows theme is set this way:

# disable images in buttons. i've only seen ugly delphi apps use this feature.
gtk-button-images = 0

Commenting out that line causes the images to reappear.
Comment 8 Michael Schumacher 2006-01-12 20:06:31 UTC
We should slap whomever added this line.
Comment 9 Michael Schumacher 2006-01-12 21:33:26 UTC
Seriously, reassign to GTK+?
Comment 10 Sven Neumann 2006-01-31 15:03:40 UTC
Of course not. GTK+ does the right thing here and for the Windows platform, gtk-button-images=0 is a reasonable default because it matches the look of the native widgets. The bug here is that GIMP abuses the stock-id property instead of manually adding the icons.
Comment 11 Sven Neumann 2006-01-31 15:07:10 UTC
Fixed in both branches:

2006-01-31  Sven Neumann  <sven@gimp.org>

	* app/tools/gimplevelstool.c (gimp_levels_tool_color_picker_new):
	manually add the icons to the color picker buttons instead of
	abusing the stock-id property. Fixes bug #325745.
Comment 12 Michael Schumacher 2006-02-08 17:02:08 UTC
*** Bug 330421 has been marked as a duplicate of this bug. ***