After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 325477 - Just make File Chooser window bigger
Just make File Chooser window bigger
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
unspecified
Other other
: Normal enhancement
: ---
Assigned To: gtk-bugs
Federico Mena Quintero
: 385011 420616 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-01-02 04:35 UTC by Marcin Lewandowski
Modified: 2009-06-12 16:19 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
patch, fixes several issues (4.71 KB, patch)
2006-11-07 13:41 UTC, Carlos Garnacho
committed Details | Review

Description Marcin Lewandowski 2006-01-02 04:35:12 UTC
Distribution: Gentoo Base System version 1.12.0_pre12
Package: gtk+
Severity: enhancement
Version: GNOME2.12.2 unspecified
Gnome-Distributor: Gentoo
Synopsis: Just make File Chooser window bigger
Bugzilla-Product: gtk+
Bugzilla-Component: GtkFileChooser
Bugzilla-Version: unspecified
Description:
It is unpleasant to browse directories with many files with File Chooser
window because it is too small. At 90% of openings I have to manually
enlarge it.

Suggestion:
Make window bigger (1,5-2 times) by default OR let window calculate
dimensions as a percentage of screen width/height (circa 60-70%) OR let
window remember last dimensions.




------- Bug created by bug-buddy at 2006-01-02 04:35 -------

Comment 1 Vincent Untz 2006-04-17 15:21:33 UTC
See also http://gnomesupport.org/forums/viewtopic.php?t=10833
Comment 2 Federico Mena Quintero 2006-04-17 17:35:17 UTC
Something is broken in the code that picks a good size.  It tries to use a window height of around 40 lines in the default font size, but that's obviously not the end result.
Comment 3 Jorge 2006-04-25 10:43:57 UTC
I'm having the same problem. Whenever I save a file, for example while downloading some file from Firefox, I get this so small 'file chooser window' size :(, it's really annoying.

I think that appart from being much better calculated the default size based on the screen resolution, it should also let the user define a _custom default_ window size and remember this setting forever; this would be great. Hope to see this bug/feature solved soon. Thanks!
Comment 4 Marcin Lewandowski 2006-10-06 20:41:27 UTC
*PING*. Sorry for hurrying, but it's really annoing thing to resize the same window  50x a day?
Comment 5 Jorge 2006-10-06 22:09:13 UTC
Yes, really it is; at least some of us agree regarding this problem. This is a major annoyance for me.
Hope someone fixes this very soon!.
Comment 6 Federico Mena Quintero 2006-10-07 00:41:45 UTC
There are various sizing bugs that need to be fixed at the same time:

- bug #151169 ("file chooser up too big")
- bug #143213
- bug #167189
- bug #153785
- bug #300334

and probably others.  We are not ignoring you; it's just that I don't have free time right now to fix this.  An analysis of the sizing bugs would be very much appreciated.
Comment 7 Marcin Lewandowski 2006-10-07 13:42:29 UTC
Can I help with something?
Comment 8 Carlos Garnacho 2006-11-07 13:41:31 UTC
Created attachment 76151 [details] [review]
patch, fixes several issues

Hi!,

I've done a small patch that fixes several issues in filechooser resizing, here's my report on the mentioned bugs:

* This one: improved, the window height is now slightly bigger, but the size request now takes into account the extra widget. Without this patch, the default size is guessed forgetting the extra widget, and when the dialog takes the default size it's told, the extra widget makes the navigation pane quite short. This is a quite widespread problem, as many apps add an extra widget.

* #151169: The file chooser was already told to shrink to 3/4 of the screen when the filechooser was bigger than the screen size, should be closed.

* #143213: this patch fixes this, there was a gtk_paned_set_position() call that made the shortcuts pane wider than it's minimum size, which is (IMHO) enough for  it.

* #167189: needs further investigation, seems like a size request/allocation events confusion. Maybe adding here a low priority idle handler to show the preview would help, showing hundreds of previews when scrolling fast definitely serves no purpose.

* #153785: Fixed by this patch, sets the window geometry min_width to the contained filechooser default size when it's in "save" or "create folder" modes.

* #300334: needs fixing in GtkPathBar, I'm going to work on that next, will attach the patch there.
Comment 9 utnubu 2006-12-03 10:39:22 UTC
I made a patch to write additional informations into the config-file ~/.config/gtk-2.0/gtkfilechooser
  <minimum_width value="1000"/> 
  <minimum_height value="700"/>
  <open_browse_expander value="false"/>
Which defines a minimum-size when the directory-browser is opened. The option 'open_browse_expander' defines whether to open the browser by default. One could add an popup-menu-line to save the values. ("Remember window size" or so)
You can find the two patches together with ubuntu-edgy-packages at http://www.fx5-1.de/~fx5/gtk/
Comment 10 Carlos Garnacho 2006-12-12 13:22:09 UTC
*** Bug 385011 has been marked as a duplicate of this bug. ***
Comment 11 Matthias Clasen 2007-02-27 04:16:54 UTC
I've committed Carlos patch
Comment 12 Diego González 2007-03-09 20:01:24 UTC
Hi,

I just compiled GTK+ from SVN trunk, i still see problems in the sizing, actually it is worse than before for me, the size of the window is the same as before the only thing that changed after the patches is the place where the spliter is presented, this time the directories and devices pane is way too small.

Comment 13 Federico Mena Quintero 2007-03-16 01:02:44 UTC
See also bug #418585, which caught a stupid bug in the auto-sizing code.
Comment 14 Diego González 2007-03-17 13:26:38 UTC
i tried GTK+ SVN trunk today, the dialog seems bigger, however the splitter is as annoying as the last time, too small to see the description of the devices, i have to move it to be able to see the devices and bookmarks properly.
Comment 15 Guillaume Tissier 2007-03-25 15:34:20 UTC
Here's a small hack to have a bigger (usable) window.
Edit your ~/.gtkrc or one of your used theme, go to section "Default", and add :
GtkScrollbar::min_slider_length = 100

You can adapt default size changing the value, 100 is enougth for me.
Comment 16 Carlos Garnacho 2007-04-11 23:48:41 UTC
*** Bug 420616 has been marked as a duplicate of this bug. ***
Comment 17 Jorge 2007-04-15 15:52:59 UTC
I'm running GNOME 2.18 under Ubuntu Feisty Fawn and this bug is still present, here's a screenshot:

http://img120.imageshack.us/my.php?image=screenshotsaveimageea9.png

I'm switching in a couple of weeks from a resolution of 1280*1024 to 1680*1050 (new monitor arriving) so my user experience will be yet worst :(

I hope to see this bug fully fixed soon (comemnt #14), this is taking so long..., first report was posted at the beginning of 2006.

Best regards!

Comment 18 wietse.koopmans 2007-04-29 10:36:30 UTC
Same here on a fresh install of Ubuntu Feisty, highly annoying, especially the "Save As..." dialog which only shows two files at a time by default.
Guillaume's "hack" gives a little relief though.
Comment 19 Jorge 2007-04-29 15:58:50 UTC
I've tried creating a ~/.gtkrc file but didn't work, where should I put Guillaume's hack ?  Thanks.

Comment 20 wietse.koopmans 2007-04-29 17:34:41 UTC
I had a file called .gtkrc-1.2-gnome2 in my home directory, this contained a link to the file: ~/.gtkrc.mine

If this is the same for you, create the file ~/.gtkrc.mine and put Guillaume's hack in there.
Comment 21 Jorge 2007-04-29 19:43:14 UTC
Thanks for your answer, I already had those files but it doesn't make any difference (logged out/in), ie: when I try to save an image from firefox the window is as small as my screenshot from post #17... I keep getting that _unusable_and_highly_annoying_window. 

PS1: IMHO this bug is wrongly classified, 'Severity' should say 'Major' as per the definition: "Major loss of functionality- menu item broken, data output extremely incorrect, or otherwise difficult/useless to use." and the 'Status' probably is also wrong, this bug has been reported a long time ago.
Comment 22 Guillaume Tissier 2007-06-16 07:16:00 UTC
This bug seems to be resolved with gtk+-2.10.13, at least on gentoo
Comment 23 Rodd Clarkson 2007-06-16 21:07:46 UTC
And it seems to be resolved on Fedora 7 with gtk2-2.10.13-1.fc7.

Actually, some of the open file dialogs are now so big that it might need a little tweaking.  For example, the dialog for opening files in the gimp is 1000x525 pixels (on a 1920x1200 display).  How is this going to affect people on smaller display resolutions?
Comment 24 Guillaume Tissier 2007-06-25 10:53:50 UTC
It seems to be depending on screen resolution ratio, actually a good thing AMHA
Comment 25 Milan Bouchet-Valat 2008-03-15 11:47:51 UTC
This has to do with Compiz (seen in Ubuntu). See https://bugs.launchpad.net/compiz/+bug/75324.
Comment 26 Milan Bouchet-Valat 2008-03-16 13:53:08 UTC
This Compiz part of the bug has just been fixed (see http://bugs.opencompositing.org/show_bug.cgi?id=839).

This should deal with the bug described for example from comment #17. Is there any reason to keep this bug open? Making this bug stuff cleaner would be nice, here we have too many issues (a sheer metabug would help).
Comment 27 Milan Bouchet-Valat 2009-06-12 16:19:56 UTC
I think that's been fixed by Federico's patches in 2.16. If you still experience the precise issue of the dialog being too small *on high resolutions*, please feel free to reopen.