After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 324702 - f-spot systematically imports photos into ~/Photos even if I tell it no to do so
f-spot systematically imports photos into ~/Photos even if I tell it no to do so
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
0.1.x
Other All
: Normal major
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2005-12-21 14:43 UTC by jonathan.protzenko
Modified: 2006-03-13 21:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fixes a couple of small problems - more details in comments (1.07 KB, patch)
2006-03-13 21:12 UTC, James Fitzsimons
none Details | Review

Description jonathan.protzenko 2005-12-21 14:43:13 UTC
Please describe the problem:
Ctrl+N opens the import dialog. Then, I want to import large amounts of photos
located on a network share (samba). This samba share is mounted into a directory
in my home directory. So when I want to import let's say, well,
~/Mounts/Photos/Sth, it copies all the contents of this folder into ~/Photos.
It's pretty annoying since I realized after having classified ~3Go of photos
that everything was copied to my HD (which I didn't want). I deleted the Photos
copied into ~/Photos but now I cannot access them anymore from F-Spot. Only the
thumbnails are shown (which is logical of course).

Steps to reproduce:
1. Open the import dialog.
2. Uncheck "copy the photos to the Photos folder"
3. Import photos located on a samba share.


Actual results:
Photos imported AND copied to ~/Photos

Expected results:
Photos imported AND NOT copied to ~/Photos

Does this happen every time?
Yes

Other information:
Both computers run up-to-date Gentoo Linux.
Comment 1 jonathan.protzenko 2005-12-21 14:54:42 UTC
Well, sorry, but it also happens with files located on my hard drive. It didn't happen with 1.0.3.
Comment 2 jonathan.protzenko 2005-12-21 15:29:41 UTC
I found the problem : the files are copied just after I have clicked "open" to open the folder containing photos. If then I delete the ~/Photos folder, then I uncheck the "Copy file to Photos folder", then I click import, it's ok. Using latest CVS version, it seems that I can delete ~/Photos after having imported, which means latest CVS registers the correct paths depending on whether I have check "copy file to..." or not, whereas 0.1.5 does not. Hope this helps.
Comment 3 jonathan.protzenko 2005-12-22 12:44:39 UTC
quick workaround I found : uncheck "copy files to..." BEFORE you select the folder. Otherwise, the behaviour is the one I have described :)
Comment 4 Aldo "Xoen" Giambelluca 2005-12-22 12:47:55 UTC
Same problem here, also here gentoo :) and f-spot 0.1.5.

Also here if I no select "copy the photos to the Photos folder" f-spot copy the imported photos into ~/Photos.

I don't know if copy to ~/Photos will should be the default because usually the photos are already into the HD and in this way there is a duplication of required HD capacity. Do not copy to ~/Photos limits in some way f-spot?
Comment 5 Aldo "Xoen" Giambelluca 2005-12-22 12:56:09 UTC
Your warkaround seems to work only the first time, after the issue return :(

I've tryed dragging the photos holding [SHIFT] and seems to work
Comment 6 Bengt Thuree 2006-02-20 11:19:49 UTC
See additional comments regarding this on Bug #318519 and in #326228 
Similar issues...
Comment 7 Adam Williamson 2006-02-22 02:23:45 UTC
+1. please fix this, very annoying. Like the original reporter, my pictures are stored on another machine and mounted across the network. I don't need a bunch of extra copies on this machine, thanks.
Comment 8 srn 2006-02-27 20:31:11 UTC
I found the same thing yesterday (I wondered why my home directory was filling up).

In 0.1.10, the problem is definately if you click on the "Don't copy" checkbox _after_ you select the folder to import from. I imported about 4.5k photos yesteday and the only ones that got copied where the directory I forgot to click the button first on.
Comment 9 Larry Ewing 2006-03-13 00:49:05 UTC
ok the photos should be properly removed now if you uncheck the copy option, no matter when you do it.
Comment 10 James Fitzsimons 2006-03-13 21:12:18 UTC
Created attachment 61206 [details] [review]
Fixes a couple of small problems - more details in comments

This patch fixes the main part of this bug where photos are still copied even when the copy check box is unchecked. 
The other minor change this patch addresses is cosmetic. If a photo fails to import the progress bar wouldn't be incremented for that photo meaning that even when importing had finished the progress bar wasn't at 100%. This looked a little bit ugly and could be confusing to some users. It will now always go to 100%.
Comment 11 Larry Ewing 2006-03-13 21:31:44 UTC
thanks for the patch, it is committed now.