After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 324452 - On bookmarked pages, change "Add Bookmark..." to "View Bookmark"
On bookmarked pages, change "Add Bookmark..." to "View Bookmark"
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Bookmarks
1.9.x
Other Linux
: Normal enhancement
: ---
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
Depends on:
Blocks:
 
 
Reported: 2005-12-19 00:59 UTC by Ed Catmur
Modified: 2006-08-11 08:16 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Ed Catmur 2005-12-19 00:59:42 UTC
Hitting Ctrl+D or Bookmarks->Add Bookmark... on an already bookmarked page brings up a dialog (bug 117643):

You already have a bookmark titled Blah for this page.
                              [View Properties] [OK]

This dialog is redundant: it would be just as useful to bring up the bookmark properties dialog. (A user who forgot they already had a bookmark will just click Close; a user who is using Add Bookmark as a shortcut to the bookmark properties will be spared a click.)

To prevent user confusion the menu item could be changed to "View Bookmark" when the current page is bookmarked.

It helps that the "Add bookmark" and "View bookmark" dialogs are near-identical; indeed, the only difference there needs to be between the two is the title, the Help topic, and the buttons: [Cancel] [OK] / [Delete] [Close].
Comment 1 Reinout van Schouwen 2005-12-19 12:48:09 UTC
I don't think that seemingly random changing menu labels is good. Otherwise, you are correct that the View and Add dialogs are similar and work is already being done on this issue.
Comment 2 Wouter Bolsterlee (uws) 2006-03-08 23:26:47 UTC
I think this feature request is obsoleted by the "Similar topic" button in the new bookmarks editor.

However, I would really welcome a visual indication that the current page is one of my bookmarks. What about adding an indicator/icon/color to the location bar, eg. a bookmark icon at right side of the location bar?
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2006-08-11 07:01:42 UTC
The icon is a good idea I would like to try doing this, is this still hack-eable or it has been fixed in 2.15?
Comment 4 Wouter Bolsterlee (uws) 2006-08-11 08:14:13 UTC
It has been fixed since a long time... whenever you try to add a bookmark for a page you already have a bookmark for, the "show similar bookmark" or "show identical bookmark" buttons become available.

Closing this bug, since the original report is no longer valid.
Comment 5 Wouter Bolsterlee (uws) 2006-08-11 08:16:53 UTC
I've opened bug #350853 for the icon issue.