GNOME Bugzilla – Bug 324283
Fix to bug 318928 breaks gnopernicus sandbox installs
Last modified: 2006-05-08 14:08:35 UTC
Gentoo installs packages to a staging area, for sandboxing. The fix to bug 318928 breaks this since it prevents make install sysconfdir=${D}/etc from working. Easy fix
Created attachment 56079 [details] [review] Use $(sysconfdir)/$(sysconfsubdir) in Makefiles
Comment on attachment 56079 [details] [review] Use $(sysconfdir)/$(sysconfsubdir) in Makefiles Patch looks fine. Please apply.
Patch committed to CVS head.
Created attachment 62010 [details] [review] Another patch to do the same. I'm curious to know how the patch I'm attaching looks because I was the submitter of bug 318928. It is supposed to achieve the same thing as the previous patch but using gnopernicusconfdir, which is, in my opinion, cleaner. Why? Because it uses a single variable and does not lead to confusion (specially while writing new code). It should now work because I changed the assignment to not expand its contents (note the single quotes) and add the required variables to the Makefile files (see the new AC_SUBST call).
OK, I've just tried the same fix I posted here (but in gdm's code) and it worked appropriately. Might you apply it? :-)
I'm having trouble seeing what the point is. It's less clean in that it introduces an extra variable that uses a single-quote hack to delay expansion. I also don't see where confusion is liable to arise with the current code.
Confusion in that "oh, I have to remember to use two different variables to specify where to install config files, where one typically just uses sysconfdir alone". Yes, gnopernicusconfdir is a new, nonstandard variable, but it is clear that it contains the path to the config dir, no matter how it was internally set. Well, not a big issue really and you could turn this around to say that it is more confusing this way. But please note that this is not a "single-quote hack". It is the correct way to define variables that hold paths in Autoconf/Automake, and the reason is to allow what you wanted in the first place. This is documented somewhere in the Autoconf/Automake info manuals, but I can't find it now...
Please reopen bugs when the fix is incomplete, etc. Otherwise it will not appear in the appropriate list and is posible to miss you comments, work etc.
Comment on attachment 62010 [details] [review] Another patch to do the same. patch applied on cvs head.