After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 323476 - EelOpenWith dialog should include entries/directory with is_nodisplay == TRUE
EelOpenWith dialog should include entries/directory with is_nodisplay == TRUE
Status: RESOLVED FIXED
Product: eel
Classification: Deprecated
Component: general
2.14.x
Other All
: Normal normal
: ---
Assigned To: Christian Neumair
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-12-07 14:53 UTC by Sebastien Bacher
Modified: 2006-03-20 17:17 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
Proposed patch (1.14 KB, patch)
2006-03-17 18:54 UTC, Christian Neumair
committed Details | Review

Description Sebastien Bacher 2005-12-07 14:53:41 UTC
This bug has been described by http://bugzilla.ubuntu.com/show_bug.cgi?id=20497

When a desktop file uses "NoDisplay=true" it's not listed by
gmenu_tree_directory_get_contents (). Some applications (like evince) or menu
editor use this option. That's an issue because gmenu-simple-editor doesn't make
possible to the user to unmask the entry then and the "open with" nautilus
dialog doesn't list the application.
Comment 1 Travis Watkins 2005-12-07 15:25:22 UTC
'NoDisplay means "this application exists, but don't display it in the menus".
This can be useful to e.g. associate this application with MIME types, so that
it gets launched from a file manager (or other apps), without having a menu
entry for it'

This is from the desktop entry spec. Alacarte is doing the right thing here.
Comment 2 Christian Neumair 2005-12-07 16:14:45 UTC
Looks like the "NoDisplay" desktop entries and directories are skipped straight
during parsing. It might be better to not skip them, and add get_no_display API
to GMenuTreeEntry and GMenuTreeDirectory.
Comment 3 Mark McLoughlin 2005-12-08 08:35:45 UTC
Committed this patch to HEAD:

  http://www.gnome.org/~markmc/code/gnome-menus-include-nodisplay.patch

Moving to eel so the new API can be used to fix EelOpenWithDialog
Comment 4 Sebastien Bacher 2006-03-17 17:46:51 UTC
still an issue with GNOME 2.14, apps like evince are not listed by "open with" dialog
Comment 5 Christian Neumair 2006-03-17 18:54:32 UTC
Created attachment 61455 [details] [review]
Proposed patch

Thanks for the quick response Mark.

Patch discussion:

http://mail.gnome.org/archives/nautilus-list/2006-March/msg00079.html
Comment 6 Christian Neumair 2006-03-20 17:17:10 UTC
Committed, closing.