After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 323348 - Load db in a thread
Load db in a thread
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-12-06 06:53 UTC by James "Doc" Livingston
Modified: 2006-01-21 01:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (5.16 KB, patch)
2005-12-06 06:54 UTC, James "Doc" Livingston 		none Details | Review
updated patch (3.63 KB, patch)
2006-01-15 08:43 UTC, James "Doc" Livingston 		none Details | Review
updated patch (3.85 KB, patch)
2006-01-17 12:19 UTC, James "Doc" Livingston 		committed Details | Review

Description James "Doc" Livingston 2005-12-06 06:53:09 UTC 
Rhythmbox takes a while to show the window after it is started, because it will
not do so until the DB in loaded. If we loaded the db in a thread, Rhythmbox
would appear to start faster.
Comment 1 James "Doc" Livingston 2005-12-06 06:54:00 UTC 
Created attachment 55672 [details] [review]
patch

Patch to do this, and makes rhythmb_commit safe to call from another thread.
Comment 2 James "Doc" Livingston 2006-01-15 08:43:39 UTC 
Created attachment 57391 [details] [review]
updated patch

Updated to cvs, and with a couple of minor fixes/improvements.
Comment 3 Jonathan Matthew 2006-01-17 11:21:19 UTC 
This achieves roughly the same effect as my patch in bug #325215, with much less hassle.  I think this is the better approach, but we could still do better.  With a cold disk cache, there's still a period of 5-10 seconds where rhythmbox is unresponsive.
Comment 4 James "Doc" Livingston 2006-01-17 12:19:59 UTC 
Created attachment 57528 [details] [review]
updated patch

For me that delay was mostly being caused by the library-monitoring starting immediately, when RB is still busy loading the db and doing stats.

This version of the patch causes it to start 10 seconds later. For me, RB's UI is semi-responsive in 2 seconds, and completely loaded in 6.
Comment 5 Alex Lancaster 2006-01-19 14:24:52 UTC 
WORKSFORME.  Nice to have the UI loaded almost immediately then the loading of new files a bit later.
Comment 6 James "Doc" Livingston 2006-01-21 01:55:50 UTC 
Committed to cvs. Some of the stuff from bug 325215, or other bugs may still be useful (I haven't checked yet).