After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 323177 - Make Iwarp have a resizable preview
Make Iwarp have a resizable preview
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Plugins
git master
Other All
: Normal enhancement
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
: 323609 394156 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-12-04 03:09 UTC by Joao S. O. Bueno
Modified: 2008-01-22 21:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Implements Preview Resizing in Iwarp plugin (16.89 KB, patch)
2005-12-04 03:13 UTC, Joao S. O. Bueno
none Details | Review

Description Joao S. O. Bueno 2005-12-04 03:09:31 UTC
IWarp plugin is currently with a default preview with at most 256 x256 pixels. 
That is too small for ths gae of digital cameras, were 2048x1400 images are 
considered small. 
 
Instead of just changing the hardcoded preview size, I added teh code needed 
for interactive resizng of the preview (by resizing the window).
Comment 1 Joao S. O. Bueno 2005-12-04 03:13:56 UTC
Created attachment 55600 [details] [review]
Implements Preview Resizing in Iwarp plugin

Also changes default preview size to a maximum of 320x320
Comment 2 Sven Neumann 2005-12-04 16:22:32 UTC
Should be possible to get away without the resize timeout. Also the code should
be using the canonical signal names ("size-allocate" instead of
"size_allocate"). But I guess we can fix that after the patch has been committed.
Comment 3 Sven Neumann 2005-12-05 13:09:17 UTC
Still somewhat ugly in a few places but I committed something based on this
patch nevertheless:

2005-12-05  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/iwarp.c: applied a modified version of a patch
	by Joao S. O. Bueno Calligaris that makes the IWarp preview
	resizable (bug #323177).
Comment 4 Sven Neumann 2005-12-09 14:14:59 UTC
*** Bug 323609 has been marked as a duplicate of this bug. ***
Comment 5 Greg 2005-12-10 00:20:11 UTC
The modifications that make IWarp preview resizable are a great solution, thank you.

I apologise but I am unable to code what I am going to ask for.

Would somebody be able to implement IWarp to be used on the regular work area.

Of course this would require the addition of a mesh/grid style selection tool.

I understand that this type of selection tool would encounter complications with
variable scaling and view but none the less can be done.
Comment 6 weskaggs 2005-12-11 16:40:47 UTC
Greg, you are basically repeating the enhancement request that is the subject of
bug 162014.
Comment 7 Sven Neumann 2007-01-08 07:30:38 UTC
*** Bug 394156 has been marked as a duplicate of this bug. ***
Comment 8 Greg 2008-01-22 20:18:59 UTC
(In reply to comment #5)
> The modifications that make IWarp preview resizable are a great solution, thank
> you.
> I apologise but I am unable to code what I am going to ask for.
> Would somebody be able to implement IWarp to be used on the regular work area.
> Of course this would require the addition of a mesh/grid style selection tool.
> I understand that this type of selection tool would encounter complications
> with
> variable scaling and view but none the less can be done.

My request was moved under 323177 whereas the Preview SIZE is not my issue.

I will now be more precise.

Preview SCALEABLITY - well over half the time a 1:1 preview is hopelessly inadequate. A Preview ZOOM allowing at least a Maximum of 400% is needed for precision artwork.

Most people are unable to work at any reasonable pixel manipulative precision at under 400% - at least for any reasonable time.

My work around is to make a copy of the selection, rescale (stretch) it for performing IWarp then rescale (shrink) and replace it.
This work around is very lossy and not good enough in most cases.

I will reiterate my ONE point to make sure I am not providing the ambiguity as suggested of my original request.

WORKABLE PREVIEW SCALABILITY - as in ZOOM
SPECIFICALLY IWarp ZOOM and keep working at the higher detail

Many thanks, 
Greg
Comment 9 Sven Neumann 2008-01-22 21:15:00 UTC
It's absolutely pointless to add comments to bug reports which are closed. Your concerns are dealt with in bug #162014.