After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 323115 - --force-shutdown does not shutdown e-d-s
--force-shutdown does not shutdown e-d-s
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Shell
2.4.x (obsolete)
Other Linux
: High critical
: ---
Assigned To: Harish Krishnaswamy
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2005-12-03 14:54 UTC by Karsten Bräckelmann
Modified: 2013-09-10 14:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix that sets the oafids to the api version rather than the base version (5.05 KB, patch)
2006-01-11 18:51 UTC, Harish Krishnaswamy
committed Details | Review
Exchange connector part of it.. (5.05 KB, patch)
2006-01-14 09:37 UTC, Sushma Rai
committed Details | Review
Another patch for exchange connector. (1.17 KB, patch)
2006-01-18 10:58 UTC, Sushma Rai
accepted-commit_now Details | Review

Description Karsten Bräckelmann 2005-12-03 14:54:32 UTC
The --force-shutdown option does not shutdown e-d-s since 2.4, like it used to.
This is a bad thing. Please add this feature back in, as described in the help:

$ evolution-2.4 --help | grep -A 1 force-shutdown
  --force-shutdown                       Forcibly shut down all Evolution
                                         components

This is a regression.
Comment 1 André Klapper 2005-12-05 14:47:14 UTC
...or the parameter explanation should be changed - i know that there are
applications that require e-d-s to keep running (e.g. gnome clock applet)

anyway, confirming.
Comment 2 Karsten Bräckelmann 2005-12-05 14:55:14 UTC
Evo, clock-applet, contact-lookup-applet, gaim, gnomemeeting, ...

They all use (or at least can use) e-d-s. If e-d-s is not running, those apps
just have to restart it. This is no big deal and is the way to go. This very
same approach worked perfectly in GNOME 2.10. There is no reason for this and
forcing the user to *kill* e-d-s if need be.

For example, there is no way to move entire accounts without this. And killing
e-d-s might lose data. That#s  what a graceful shutdown is for.

Regression.
Comment 3 Andrew Case 2005-12-11 01:20:54 UTC
I would like to be able to restart e-d-s without killing it myself, please fix
me!  Well the bug, not me, but you know what I mean.
Comment 4 André Klapper 2006-01-09 00:37:30 UTC
also see bug 253484 and bug 253904
Comment 5 Karsten Bräckelmann 2006-01-10 02:45:15 UTC
Please, oh please -- do NOT make me go through the hell of using 'kill' when talking clueless users through the steps to recreate their important data.

'evolution --force-shutdown' *really* has to stop e-d-s. Respawning is fine. I don't care. But it must be shut down gracefully.

I am serious. Get this in ASAP.

Whoever wants to argue about this should read the IRC logs *first*.
Comment 6 Karsten Bräckelmann 2006-01-10 02:47:58 UTC
Do not make me go though this... "yet another 6 months and yet another major Evo version" I mean.

The need to use this *ugly* hack to recreate BerkeleyDB files in 2.4 is more than enough. Considering tonight, it is more than I can take already.
Comment 7 André Klapper 2006-01-10 11:16:06 UTC
booooy, just wrote the same mail, explaining "ps ax|grep" and kill. this really sucks.
Comment 8 Srinivasa Ragavan 2006-01-11 08:33:44 UTC
Yes right.

evolution/tools/killev.c (main)

	add_matching_repo_id ("IDL:GNOME/Evolution/Component:" BASE_VERSION);
	add_matching_repo_id ("IDL:GNOME/Evolution/DataServer/CalFactory:" DATASERVER_API_VERSION);
	add_matching_repo_id ("IDL:GNOME/Evolution/DataServer/BookFactory:" DATASERVER_API_VERSION);
	add_matching_repo_id ("IDL:GNOME/Evolution/Importer:" BASE_VERSION);
	add_matching_repo_id ("IDL:GNOME/Evolution/IntelligentImporter:" BASE_VERSION);
	add_matching_repo_id ("IDL:GNOME/Spell/Dictionary:0.3");

It uses BASE_VERSION which is 1.6 (now), but the IDL File uses IDL:GNOME/Evolution/Importer:API_VERSION (1.2) in eds. 

Harish is looking into the issue.
Comment 9 Harish Krishnaswamy 2006-01-11 18:51:23 UTC
Created attachment 57170 [details] [review]
Fix that sets the oafids to the api version rather than the base version

No..the above code in Evolution is just fine. It is the oafids in EDS that need to be corrected. Posted a patch for review.
2.4 requires a different patch with the same logic. shall post it tomorrow.
Comment 10 Karsten Bräckelmann 2006-01-11 21:07:37 UTC
A very similar patch wouldn't happen to fix bug 323115 too, would it?
Comment 11 Karsten Bräckelmann 2006-01-11 21:08:19 UTC
Doh! I mean bug 323116.
Comment 12 Harish Krishnaswamy 2006-01-12 09:21:19 UTC
Right. I will add the change along with the fix for the gnome-2-12 branch.
Comment 13 Srinivasa Ragavan 2006-01-12 09:44:28 UTC
Harish,

Looks fine. Tried and it worked too ;-) 
Comment 14 Sushma Rai 2006-01-14 09:37:04 UTC
Created attachment 57330 [details] [review]
Exchange connector part of it..

With the above patch, exchange address books and calendars are not getting loaded.
Attached the fix for the same.
Comment 15 Karsten Bräckelmann 2006-01-14 22:20:41 UTC
OK, if I understand the recent comments correctly, this is going to fix this issue for e-d-s and exchange-storage in one fell swoop. Going to mark bug 323116 a duplicate of this then and adjust the summary.

Please re-open bug 323116 if these fixes are *not* going to address the exchange-storage issue for HEAD and gnome-2-12 branch as well.

And please confirm both issues are going to be fixed in both branches. TIA.
Comment 16 Karsten Bräckelmann 2006-01-14 22:22:32 UTC
*** Bug 323116 has been marked as a duplicate of this bug. ***
Comment 17 Karsten Bräckelmann 2006-01-14 22:23:46 UTC
Summary adjusted. Thanks for trying to keep me sane. :)
Comment 18 Harish Krishnaswamy 2006-01-16 14:00:56 UTC
No - 323116 is not a dupe of this bug. restoring the summary back.
Comment 19 Sushma Rai 2006-01-18 10:58:11 UTC
Created attachment 57580 [details] [review]
Another patch for exchange connector.

Corrected the DataServer BookFactory and CalFactory versions also.
Comment 20 Sushma Rai 2006-01-27 12:27:13 UTC
Committed exchange connector fixes to gnome-2-12 branch,
Comment 21 Karsten Bräckelmann 2006-01-27 16:12:35 UTC
Now I'm confused. This bug already was CLOSED FIXED, and after that a patch is being committed to gnome-2-12.

What's the exact status of this bug? Are *all* relevant bits committed to HEAD and the stable gnome-2-12 branch?
Comment 22 Karsten Bräckelmann 2006-02-15 21:19:32 UTC
*poke*  Does anyone care to explain comment 21?

Adding Sushma to the Cc list.
Comment 23 Sushma Rai 2006-02-16 06:02:59 UTC
Patches are committed to both stable gnome-2-12 branch and cvs head.