After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 322874 - [PAD] pad_alloc_buffer should not call set_caps
[PAD] pad_alloc_buffer should not call set_caps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal blocker
: 0.10.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-11-30 19:50 UTC by Wim Taymans
Modified: 2005-12-05 13:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
pad to add new function with old behaviour (5.46 KB, patch)
2005-12-05 09:43 UTC, Wim Taymans 		none Details | Review
Script to sed the plugins (331 bytes, text/plain)
2005-12-05 10:32 UTC, Andy Wingo 		  Details
updated patch (6.03 KB, patch)
2005-12-05 12:25 UTC, Wim Taymans 		none Details | Review

Description Wim Taymans 2005-11-30 19:50:05 UTC 
pad_alloc_buffer currently calls the setcaps function when a buffer with
different caps was allocated by the downstream peer element. The problem with
this is that it makes writing certain plugins much harder as they might not be
able to renegotiate at that time, specifically basetransform.
Comment 1 Andy Wingo 2005-12-04 21:42:29 UTC 
Damn you wim, we should have gotten this in last week. Why did you let it sit
this long? And what should we do about it?
Comment 2 Wim Taymans 2005-12-05 09:43:26 UTC 
Created attachment 55623 [details] [review]
pad to add new function with old behaviour

This patch adds a gst_pad_alloc_buffer_and_set_caps that has the old behaviour.
Comment 3 Andy Wingo 2005-12-05 10:32:45 UTC 
Created attachment 55625 [details]
Script to sed the plugins

Run this script on all C files to change calls from alloc_buffer to
alloc_buffer_and_set_caps.
Comment 4 Thomas Vander Stichele 2005-12-05 12:13:40 UTC 
ok to commit *PROVIDED* that the documentation is updated *correctly* (ie, both
need to show up in the output of gtk-doc, which with the current patch is not
the case)
Comment 5 Wim Taymans 2005-12-05 12:25:53 UTC 
Created attachment 55630 [details] [review]
updated patch
Comment 6 Andy Wingo 2005-12-05 13:05:20 UTC 
Totally in now.