After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 322083 - Missing #includes and other prototype warnings
Missing #includes and other prototype warnings
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
2.8.x
Other Mac OS
: Normal trivial
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2005-11-21 23:02 UTC by Daniel Macks
Modified: 2005-11-22 07:40 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Daniel Macks 2005-11-21 23:02:08 UTC
Version details: 2.8.0.6

To cure some warnings on darwin:

auth.c: In function `add_auth_entry':
auth.c:96: warning: implicit declaration of function `malloc'
auth.c:96: warning: assignment makes pointer from integer without a cast
auth.c:106: warning: assignment makes pointer from integer without a cast
auth.c:108: warning: implicit declaration of function `free'
auth.c:123: warning: assignment makes pointer from integer without a cast

glade-helper.c: In function `glade_helper_load':
glade-helper.c:66: warning: implicit declaration of function `exit'

add #include <stdlib.h> to daemon/auth.c and vicious-extensions/glade-helper.c.
Normal linuxish platforms would probably want malloc.h for auth.c (or maybe even
have that already via some earlier #include spaghetti). OTOH, darwin doesn't
have a malloc.h header at all, so if you do add #include <malloc.h> for other
folks, please wrap it in a #if HAVE_MALLOC_H via AC_CHECK_HEADERS.

Also this one:

gdmchooser.c:179: warning: no previous prototype for `gdm_kill_thingies'

which is probably related to:

greeter.c:1164: warning: `gdm_kill_thingies' defined but not used

This: 

gdmsetup.c: At top level:
gdmsetup.c:1470: warning: return type defaults to `int'
gdmsetup.c:1470: warning: no previous prototype for `include_all_toggle'

is probably a missing "static void".
Comment 1 Brian Cameron 2005-11-22 07:40:35 UTC
Fixed in CVS head and 2.12 branches.