After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 321945 - No longer automatically downloading podcasts
No longer automatically downloading podcasts
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Podcast
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-11-20 17:31 UTC by Ryan P Skadberg
Modified: 2006-04-16 17:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch? (8.26 KB, patch)
2006-04-12 11:25 UTC, Jonathan Matthew
none Details | Review
oops (9.40 KB, patch)
2006-04-12 22:03 UTC, Jonathan Matthew
none Details | Review
patch again (9.49 KB, patch)
2006-04-16 01:50 UTC, Jonathan Matthew
none Details | Review

Description Ryan P Skadberg 2005-11-20 17:31:36 UTC
Distribution/Version: Fedora Core Rawhide

Seems like somewhere in the podcast work, the automatic downloads of new
podcasts stopped.  This is sort of important functionality for podcasts.
Comment 1 Ryan P Skadberg 2005-11-28 23:16:31 UTC
This made it in to 0.9.2 and is REALLY frustrating, could someone take a look?
Comment 2 Jonathan Matthew 2006-01-02 11:19:59 UTC
It seems to be working for me.  What update interval are you using?
Comment 3 James "Doc" Livingston 2006-01-02 11:23:21 UTC
I've seen this occasionally. The newest podcast gets queued for downloading, and most of the time it starts downloading (if one already isn't) but occasionally it gets queued without starting. No idea why.
Comment 4 Ryan P Skadberg 2006-01-03 19:52:06 UTC
I actually see it the exactly opposite way.  Almost always it doesn't download, but once in a blue moon, it actually does do it.

Update Interval is set to One Hour.
Comment 5 Sebastien Bacher 2006-01-04 11:09:51 UTC
There is an Ubuntu bug about that: http://bugzilla.ubuntu.com/show_bug.cgi?id=21855

"(gst 0.10)

I configured RB to check for new podcasts every hour. But, it doesn't work, I
always have to check the feeds and download manually."

Ubuntu dapper has a package of CVS from 2 days ago
Comment 6 Baptiste Mille-Mathias 2006-01-17 16:19:39 UTC
Change to "Podcast" Component
Comment 7 Christophe Fergeau 2006-03-11 17:41:01 UTC
Is that still broken in recent CVS versions?
Comment 8 Ryan P Skadberg 2006-03-11 18:17:25 UTC
Yeah, I still have this issue.  It seems to download some podcasts, but not others.
Comment 9 Hidde Brugmans 2006-03-29 13:12:12 UTC
Highly annoying.
Comment 10 Jonathan Matthew 2006-04-12 11:25:19 UTC
Created attachment 63303 [details] [review]
patch?

Please test this.  I don't really know if this fixes the problem in question, but I think it should.
Comment 11 Ryan P Skadberg 2006-04-12 15:53:38 UTC
Doesn't compile :(

 gcc -DHAVE_CONFIG_H -I. -I. -I.. -DGNOMELOCALEDIR=\"/usr/share/locale\" -DG_LOG_DOMAIN=\"Rhythmbox\" -I.. -I../lib -I../rhythmdb -I../widgets -I../shell -I../metadata -I../library -I../lib -DORBIT2=1 -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libgnomeui-2.0 -I/usr/include/libgnome-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/libart-2.0 -I/usr/include/gconf/2 -I/usr/include/libbonoboui-2.0 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/gnome-keyring-1 -I/usr/include/orbit-2.0 -I/usr/include/libbonobo-2.0 -I/usr/include/bonobo-activation-2.0 -I/usr/include/freetype2 -I/usr/include/libxml2 -I/usr/include/libglade-2.0 -I/usr/include/gnome-vfs-module-2.0 -pthread -I/usr/include/gstreamer-0.10 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -Wcomment -Wformat -Wnonnull -Wimplicit-int -Wimplicit -Wmain -Wmissing-braces -Wparentheses -Wsequence-point -Wreturn-type -Wswitch -Wtrigraphs -Wunused-function -Wunused-label -Wunused-value -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wcast-align -Wall -Werror -std=gnu89 -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i686 -mtune=generic -fasynchronous-unwind-tables -MT rb-podcast-manager.lo -MD -MP -MF .deps/rb-podcast-manager.Tpo -c rb-podcast-manager.c  -fPIC -DPIC -o .libs/rb-podcast-manager.o
rb-podcast-manager.c:754: error: conflicting types for 'rb_podcast_manager_add_post'
rb-podcast-manager.h:88: error: previous declaration of 'rb_podcast_manager_add_post' was here
make[2]: *** [rb-podcast-manager.lo] Error 1
make[2]: Leaving directory `/usr/src/redhat/BUILD/rhythmbox-0.9.3.99.cvs200604111134/podcast'
make[1]: *** [all-recursive] Error 1
Comment 12 Jonathan Matthew 2006-04-12 22:03:54 UTC
Created attachment 63338 [details] [review]
oops

this should compile, at least..
Comment 13 Ryan P Skadberg 2006-04-13 16:44:11 UTC
Seems to work for me.
Comment 14 Ryan P Skadberg 2006-04-13 22:12:26 UTC
I lied.  Almost works.  The problem is that some feeds publish multiple things on the same time in the same day and since the time is the same, the second one doesn't get downloaded.  Should just be a switch of > to >= and it should be good.

Thanks!
Comment 15 Jonathan Matthew 2006-04-14 00:14:09 UTC
I'm not entirely sure what you mean here.  If there are multiple new posts with the same time/date, they should all be downloaded?
Comment 16 Ryan P Skadberg 2006-04-14 00:37:30 UTC
If they are different, hell yes :)

Sites like IT Conversations release multiple podcasts daily, yet they are all marked as midnight that morning.
Comment 17 Jonathan Matthew 2006-04-16 01:50:36 UTC
Created attachment 63617 [details] [review]
patch again

This should download all entries with the most recent publication date.  I haven't tested that it actually does this, because I can't be bothered tracking down a suitable feed.
Comment 18 Ryan P Skadberg 2006-04-16 17:15:44 UTC
This seems to be working fine for me, and since we are at the very beginning of a new development cycle, might as well get it in to CVS.  So, I committed it.