Bug 321930 – another daap crash

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 321930 - another daap crash


Summary:	another daap crash


Status:	RESOLVED FIXED

Product:	rhythmbox
Classification:	Other
Component:	general
Version:	HEAD
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	RhythmBox Maintainers
QA Contact:	RhythmBox Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2005-11-20 15:15 UTC by James "Doc" Livingston
Modified:	2005-11-22 04:13 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
patch (39.27 KB, patch) 2005-11-21 11:45 UTC, James "Doc" Livingston	committed	Details \| Review

Description James "Doc" Livingston 2005-11-20 15:15:22 UTC

This is a reproducable crash when using CVS as a client to talk to RB 0.9.1, and
the server quits. The logout response callback is being called after the source
has been finalised.

+ Trace 64146

#0 rb_daap_source_disconnect_cb
at rb-daap-source.c line 604
#1 rb_daap_connection_do_something
at rb-daap-connection.c line 1482
#2 rb_daap_connection_state_done
at rb-daap-connection.c line 1348
#3 handle_logout
at rb-daap-connection.c line 1243
#4 http_response_handler
at rb-daap-connection.c line 759
#5 IA__g_cclosure_marshal_VOID__VOID
at gmarshal.c line 77
#6 IA__g_closure_invoke
at gclosure.c line 492
#7 signal_emit_unlocked_R
at gsignal.c line 2485
#8 IA__g_signal_emit_valist
at gsignal.c line 2244
#9 IA__g_signal_emit
at gsignal.c line 2288
#10 soup_message_finished
from /usr/lib/libsoup-2.2.so.8
#11 soup_session_send_message
from /usr/lib/libsoup-2.2.so.8
#12 soup_session_cancel_message
from /usr/lib/libsoup-2.2.so.8
#13 soup_session_abort
from /usr/lib/libsoup-2.2.so.8
#14 IA__g_cclosure_marshal_VOID__INT
at gmarshal.c line 216
#15 IA__g_closure_invoke
at gclosure.c line 492
#16 signal_emit_unlocked_R
at gsignal.c line 2485
#17 IA__g_signal_emit_valist
at gsignal.c line 2244
#18 IA__g_signal_emit
at gsignal.c line 2288
#19 soup_connection_reauthenticate
from /usr/lib/libsoup-2.2.so.8
#20 IA__g_cclosure_marshal_VOID__INT
at gmarshal.c line 216
#21 soup_base64_decode
from /usr/lib/libsoup-2.2.so.8
#22 IA__g_closure_invoke
at gclosure.c line 492
#23 signal_emit_unlocked_R
at gsignal.c line 2485
#24 IA__g_signal_emit_valist
at gsignal.c line 2244
#25 IA__g_signal_emit
at gsignal.c line 2288
#26 soup_socket_new
from /usr/lib/libsoup-2.2.so.8
#27 g_io_unix_dispatch
at giounix.c line 162
#28 IA__g_main_context_dispatch
at gmain.c line 1934
#29 g_main_context_iterate
at gmain.c line 2565
#30 IA__g_main_loop_run
at gmain.c line 2769
#31 bonobo_main
from /usr/lib/libbonobo-2.so.0
#32 main
at main.c line 379

Comment 1 Alex Lancaster 2005-11-21 08:10:05 UTC

Could be related to bug #322007

Comment 2 James "Doc" Livingston 2005-11-21 11:45:13 UTC

Created attachment 55017 [details] [review]
patch

This patch GObject-ifies RBDaapConnection, fixes the problem of it being freed
when still in use, and fixes a double-free of some memory. It fixes the crash
for me.

Comment 3 James "Doc" Livingston 2005-11-22 04:13:43 UTC

Comment on bug 322007 indicated that both bugs are fixed by the patch. Committed
to cvs.