After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 320532 - [faac] set output samplerate and number of channels
[faac] set output samplerate and number of channels
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.9.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-11-02 16:57 UTC by Josef Zlomek
Modified: 2005-11-16 18:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Caps fixed (928 bytes, patch)
2005-11-02 16:58 UTC, Josef Zlomek 		rejected Details | Review

Description Josef Zlomek 2005-11-02 16:57:49 UTC 
Because gst_faac_src_setcaps was set as a setcaps function of the srcpad, it was
called recursively and soemhow it cleared the rate and channels fields from the
capabilities. So the downstream elements could not find out the rate and
channels, which caused many problems.

The attached patch does not set the setcaps function for srcpad, and stops
trying to set caps of srcpad when it has already succeeded.
Comment 1 Josef Zlomek 2005-11-02 16:58:22 UTC 
Created attachment 54235 [details] [review]
Caps fixed
Comment 2 Tim-Philipp Müller 2005-11-15 16:50:48 UTC 
Should be fixed now (I fixed it a bit differently, as it all looked a bit
dodgy).  Please reopen the bug if it still does not work for you.


2005-11-15  Tim-Philipp Muller  <tim at centricular dot net>

        * ext/faac/gstfaac.c: (gst_faac_base_init), (gst_faac_init),
        (gst_faac_sink_setcaps), (gst_faac_configure_source_pad),
        (gst_faac_chain):
          Set proper caps on source pad (#320532).

Cheers
 -Tim
Comment 3 Josef Zlomek 2005-11-16 11:59:48 UTC 
It works well.
Comment 4 Tim-Philipp Müller 2005-11-16 18:10:48 UTC 
Thanks for confirming. Marking at RESOLVED again to make sure Thomas' release
scripts don't miss it.