GNOME Bugzilla – Bug 320211
DnD from bookmarks menu to toolbar would be nice
Last modified: 2011-12-23 17:48:19 UTC
The bookmarks menu is a quick way to locate a bookmark or topic. Being able to drag-and-drop from the menu to the toolbar would allow the user to treat the toolbar as a "quick access" or "desktop". For example, when I shop for something online I tend to bookmark a number of pages and add them to the 'Shopping' topic. It's nice if I can quickly drag the Shopping topic to my toolbar. The same can be said when working on other lists of pages (eg. all Epiphany bugs that I'm interested in ;).
Created attachment 54069 [details] [review] Patch to implement described behaviour.
harves, did you include this one in one of your other patches? did chpe accept it?
I've included it, though chpe is unlikely to accept that portion of the patch. I've also been told (mpt? spark? can't remember) that I should use Alt as a modifier. That is, press Alt and the cursor turns to a hand allowing you to DnD bookmarks/topics to the toolbar. I need to work out how to implement that bit.
This feature seems to work in latest CVS. Can this bug be closed?
Doesn't work here... maybe you have the patch applied? :)
Hmmm... seems I was mistaken. I guess I misunderstood: dragging bookmarks from the bme to the toolbar does work; dragging bookmarks from the menu does not.
Created attachment 78909 [details] [review] Updated patch against CVS HEAD Works perfect
I'll apply the patch to my build and try it for a few days to see if I like the feature.
moo?
I'm not convinced that DND from menu items is a good idea...
Hehe. I've heard that before. ;) The critical difference between a "regular" menu and the "bookmark" menu is that individual bookmarks and the bookmark menu itself are user-editable. The reasoning is as follows. Most items in application menus are simple actions. But if the user can add/remove/rename/edit something, then clearly it is an object and not an action (in my mind you can change an object, but you can only destroy/create an action). As the user can add/remove/rename/edit their bookmarks, they will consider them to be objects, and so should be treated as such. Even though they appear in the menu, they should be drag-droppable just as objects are. Look at the most common example of a user-editable menu: the "Applications" or "Foot" menu on the Gnome panel. Items within that menu are drag-droppable to the panel, or to the desktop, or anywhere else that kind of *object* can be placed. Such shortcuts are really *objects*, and not actions, and are treated as such. I claim this is a valid interpretation of the HIG, or should be a modification to the HIG.
Items in the GNOME panel menu also have a context menu. If bookmark menu items are "really objects", should we enable that too then? I remember that Galeon did this, but I'm not sure that's the direction we should be heading in.
Moving Severity:enhancement bugs off of 2.20 target.
any final decision on this?
I'd prefer some input from the usability team first. Apart from the main menu, I don't think there is any other app in GNOME that allows DnD of menu items, whether they are simple actions or not.
This is no/won't be longer possible with Epiphany 3.4