GNOME Bugzilla – Bug 320198
Port to libgda 2
Last modified: 2007-05-08 19:55:37 UTC
Half-done patch attached.
Created attachment 54057 [details] [review] glom.patch
Created attachment 54058 [details] [review] glom.patch
Created attachment 75126 [details] [review] glom_port_libgdamm3_halfdone.patch The port is now more difficult because of the GdaValue->GValue change. But here is a half-done patch. One problem at the moment is how to, for instance, easily declare a Glib::Value<guchar*> that will be a GValue of GDA_TYPE_BINARY.
Created attachment 75758 [details] [review] glom_port_libgdamm3_halfdone2.patch
Note that the use of Glib::ValueBase in that patch should probably be replaced by Gnome::Gda::Value now.
Created attachment 85666 [details] [review] Port to libgda3 This is a patch that merges the GLOM_LIBGDA3 branch to trunk. It makes glom use the new libgda3 API and pygda3. Issues while porting to the new API are noted in the TODO file, especially the database creation still needs a better solution. Make sure you have the latest pygda and libgdamm from SVN.
Created attachment 85668 [details] [review] Port to libgda3 This patch also includes some cleanup I did today.
So does this more or less work?
It basically works, although I still want to tackle the issues noted in the TODO file. Loading the small business example crashes it. This might have something to do with changed escaping policy in libgda.
I will take a look at this in a week or two. Well done.
According to your latest ChangeLog entry, the Small Business example does still crash for you. I actually had it working already after Vivien fixed a bug in libgda (#427605). With the latest code, it does not crash, but also does not load the critical entry (the one with the picture). I am going to have a look at that.
Yes, I can now create from an example without crashing. Excellent. Regarding the picture data, I see this error on the command-line. Well, it's only the last part of the error: WARNING: nonstandard use of \\ in a string literal LINE 1: ...,'','','','','Italy','',NULL,'','Yodda Yossarian','\\211PNG\... ^ HINT: Use the escape string syntax for backslashes, e.g., E'\\'.
Did you apply the patch in #433687 to libgda? I do not see any warning or error with it.
> Did you apply the patch in #433687 to libgda? I thought that this had been applied already. Could you please check and apply it if necessary - permission seems to have been given, and you have my permission too.
It seems to work very well. I fixed the error above, which I think was unrelated. Please merge this back into svn trunk when you have a chance, and then close this bug. It will be great to finally have this done.
Committed.