GNOME Bugzilla – Bug 320157
possible cleanups for gnome-control-center
Last modified: 2005-11-14 16:17:29 UTC
This patch contains a bunch of cleanups. Please comment and I'll try to fix up any issues asap.
Created attachment 54037 [details] [review] possbile cleanups
ok, going one by one: * capplets/accessibility/at-properties/main.c: looks good. * capplets/common/capplet-stock-icons.c: looks good. * capplets/common/gnome-theme-info.c: shouldn't we, instead of ignoring the VFS result code from another call, check if for every gnome_vfs call? * capplets/default-applications/gnome-default-applications-properties.c: if you remove the call to create_dialog, I think the dialog would never be created. * capplets/display/main.c: again, shouldn't we do something with the status code from XRRSetScreenConfigAndRate? * capplets/keybindings/eggcellrendererkeys.c: looks good. * capplets/keybindings/gnome-keybinding-properties.c: looks good. * capplets/keyboard/gnome-keyboard-properties.c: looks good. * capplets/mouse/gnome-mouse-properties.c: looks good. * capplets/theme-switcher/gnome-theme-details.c: looks good. * capplets/theme-switcher/gnome-theme-installer.c: install_dialog_response is getting a GladeXML as the user_data argument, not a GtkWidget. ... Could you please fix those (and probably others on the files I didn't review) and send the patch again to gnomecc-list@?
I've dropped the bad parts now and will send an updated patch to the list soon.
Created attachment 54603 [details] [review] updated patch
Commited to both branches.