After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 320157 - possible cleanups for gnome-control-center
possible cleanups for gnome-control-center
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-10-29 09:29 UTC by Kjartan Maraas
Modified: 2005-11-14 16:17 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
possbile cleanups (32.77 KB, patch)
2005-10-29 09:29 UTC, Kjartan Maraas
needs-work Details | Review
updated patch (42.45 KB, patch)
2005-11-10 18:09 UTC, Kjartan Maraas
none Details | Review

Description Kjartan Maraas 2005-10-29 09:29:29 UTC
This patch contains a bunch of cleanups. Please comment and I'll try to fix up
any issues asap.
Comment 1 Kjartan Maraas 2005-10-29 09:29:54 UTC
Created attachment 54037 [details] [review]
possbile cleanups
Comment 2 Rodrigo Moya 2005-10-31 12:45:29 UTC
ok, going one by one:

* capplets/accessibility/at-properties/main.c: looks good.
* capplets/common/capplet-stock-icons.c: looks good.
* capplets/common/gnome-theme-info.c: shouldn't we, instead of ignoring the VFS
result code from another call, check if for every gnome_vfs call?
* capplets/default-applications/gnome-default-applications-properties.c: if you
remove the call to create_dialog, I think the dialog would never be created.
* capplets/display/main.c: again, shouldn't we do something with the status code
from XRRSetScreenConfigAndRate?
* capplets/keybindings/eggcellrendererkeys.c: looks good.
* capplets/keybindings/gnome-keybinding-properties.c: looks good.
* capplets/keyboard/gnome-keyboard-properties.c: looks good.
* capplets/mouse/gnome-mouse-properties.c: looks good.
* capplets/theme-switcher/gnome-theme-details.c: looks good.
* capplets/theme-switcher/gnome-theme-installer.c: install_dialog_response is
getting a GladeXML as the user_data argument, not a GtkWidget.
...

Could you please fix those (and probably others on the files I didn't review)
and send the patch again to gnomecc-list@?
Comment 3 Kjartan Maraas 2005-11-01 10:01:18 UTC
I've dropped the bad parts now and will send an updated patch to the list soon.
Comment 4 Kjartan Maraas 2005-11-10 18:09:21 UTC
Created attachment 54603 [details] [review]
updated patch
Comment 5 Kjartan Maraas 2005-11-14 16:17:29 UTC
Commited to both branches.