After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 320146 - deskbar should propose which mozilla/firefox search engines to display in the prefs
deskbar should propose which mozilla/firefox search engines to display in the...
Status: RESOLVED FIXED
Product: deskbar-applet
Classification: Deprecated
Component: general
Git master
Other Linux
: Low enhancement
: 2.22
Assigned To: Deskbar Applet Maintainer(s)
Deskbar Applet Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2005-10-29 05:14 UTC by Dan Ballard
Modified: 2007-12-03 17:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Implementation (9.28 KB, patch)
2006-02-13 09:10 UTC, Nigel Tao
committed Details | Review
Glade file for previous patch (6.28 KB, text/plain)
2006-02-13 09:11 UTC, Nigel Tao
  Details

Description Dan Ballard 2005-10-29 05:14:52 UTC
I like the web search feature but I only use google and have it selected in
firefox.  I wish deskbar would/could pick up on this as I had tp push it's
priority down so other options weren't drowned in the menu under several search
engines I never use.  And removing them from firefox appears non trival. 
Thanks. Otherwise deskbar is rocking socks and I love it.
Comment 1 Raphael Slinckx 2005-10-29 13:22:13 UTC
This is a planned feature, the way we will do it is still unclear.
The current best idea is to resort to keyboard shortcuts for each search engine,
for example typing "test" in entry then hitting ctrl-g triggers a google search.

Removing the unused searh engines in firefox seems to be the best way,
unfortunately firefox is very sucky in that point of view. Better use epiphany :P
Comment 2 Raphael Slinckx 2006-02-11 14:48:04 UTC
If someone wants to write a patch, i think you can read search.rdf in ~/mozilla/firefox/xxxx/search.rdf, and extract from there the primary search engine..
Comment 3 Nigel Tao 2006-02-12 19:33:53 UTC
I think it's in ~/.mozilla/firefox/xxxx/prefs.js, with a line like
user_pref("browser.search.selectedEngine", "Google");
Comment 4 Nigel Tao 2006-02-13 09:10:01 UTC
Created attachment 59240 [details] [review]
Implementation

Voila.  Patch also fixes a couple of Wether->Whether typos in comments/schemas (which might need a stringe change notification?), and removes the unused  _on_customize_search_engines function in deskbar/handlers/mozilla.py.
Comment 5 Nigel Tao 2006-02-13 09:11:42 UTC
Created attachment 59241 [details]
Glade file for previous patch

Oops, forgot the new glade file for the patch.
Comment 6 Raphael Slinckx 2006-02-13 22:10:51 UTC
This has been comitted to HEAD. I did it because we're near string-freeze, so at least the strings are in. The code will be re-worked a bit after the release.

Thanks !
Comment 7 Nigel Tao 2006-02-14 02:57:18 UTC
I'm also thinking that the /apps/deskbar/mozilla/show_only_primary_search gconf key should default to TRUE rather than FALSE, since that seems the nicer out-of-the-box experience, but again that's a post-2.14 thing.
Comment 8 Raphael Slinckx 2006-02-14 19:35:21 UTC
I think that since firefox doesn't provide any way to remove engines, we should maybe present a list of engines, with checkboxes so users can select which engine to use (and enable them al by default).

Changing title to reflet that

But like you said this is post 2.14