After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 319683 - select by colour broken on GRAYA drawables/projection
select by colour broken on GRAYA drawables/projection
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Tools
2.3.x
Other All
: Normal normal
: 2.2
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2005-10-24 22:40 UTC by Liam Quin
Modified: 2008-01-15 14:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
bug.png: a test case (sample image). (33.59 KB, image/png)
2005-10-24 22:41 UTC, Liam Quin
Details
screenshot after using colour selection tool (78.24 KB, image/png)
2005-10-24 22:42 UTC, Liam Quin
Details

Description Liam Quin 2005-10-24 22:40:03 UTC
Distribution/Version: Mandriva Cooker

see sample image attached...

[1] choose the Colour Picker tool (shift-O by default)
[2] in the colour picker tool options, choose a threshold
    of (say) 16, and select Sample merged.  Other settings
    seem to make no difference to this bug.
[3] click on the black horizontal bar near the top of the
    sample image.
[4] Note that parts of the image are not highlighted.
    See the attachment "bug-screenshot.png", which has a
    red circle around part of the image.  If you use the
    colour picker in here you'll see that the area is black,
    but if you go back to select-by-colour and hold down shift,
    and click in there (in the original image, not the screen
    shot!) that part of the image is still not selected,
    including the pixel you clicked on with the select tool!
Comment 1 Liam Quin 2005-10-24 22:41:26 UTC
Created attachment 53857 [details]
bug.png: a test case (sample image).
Comment 2 Liam Quin 2005-10-24 22:42:23 UTC
Created attachment 53858 [details]
screenshot after using colour selection tool
Comment 3 Michael Natterer 2005-10-24 23:30:55 UTC
Actually it depends on the alpha channel. GRAYA doesn't work, everything
else does. Changing summary accordingly.
Comment 4 Michael Natterer 2005-10-25 00:21:43 UTC
Fixed in my tree, will commit tomorrow.
Comment 5 Michael Natterer 2005-10-25 16:19:39 UTC
Fixed in both branches:

2005-10-25  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpimage-contiguous-region.c
	(struct ContinuousRegionData)
	(gimp_image_contiguous_region_by_color)
	(contiguous_region_by_color): the color samples are always RGB or
	RGBA, so always compare 3 or 4 bytes of pixel data, and not just
	the number of bytes of the drawable/projection. Fixes "select by
	color" on GRAYA (bug #319683).