GNOME Bugzilla – Bug 318151
menu tooltips are hard to read when using HighContrastInverse theme
Last modified: 2006-01-03 14:56:21 UTC
A menu tooltip normally has a black boundry so it is easy to see. However, when you use the HighContrastInverse theme it is really hard to see the Tooltip. I assume this is because the black boundry doesn't show up well with the black background used in the HighContrastInverse theme. It looks very messy. I notice this problem when running gdmlogin and I took a look at other GNOME programs and it seems hard to find another example of a GNOME program that uses tooltips in menus. To see this problem in gdmlogin, do the following: Edit /etc/gdm/gdm.conf so that "AllowGtkThemeChange=true" and set the environment variable DOING_GDM_DEVELOPMENT=1. Then you can run gdmlogin in test mode from gnome-session. Using the "Theme" menu, change the theme it is using to HighContrastInverse, and you can see the problem with the tooltips being very hard to read. Should GDM not be using tooltips in menus at all, or should GTK be made smarter so that the tooltips are visible even when the theme background is also black? Or something else?
IA tooltip has no clue that it is being used in a menu (and thus, tooltips on menus don't work very well. Though I doubt they are a good idea to start with... But that's a different issue.) Are you saying that this is some problem that doesn't occur with tooltips not-on-menus with HighContrastInverse? Presumably the black border should be reversed for that theme... for the default theme engine, the border is drawn harcoded to black, but the High-Contrast engine could definitely do something differet (draw_flat_box with a detail of "tooltip")
Created attachment 56714 [details] [review] propsed fix This patch uses gtk_paint_box to draw tooltips. So they are drawn in the same way as menus, etc. are. That is for the HighContrastInverse theme a white border and dark background.
Thanks for the patch Benjamin. I had been meaning to get round to doing this for some time. Please go ahead and commit your patch to the gtk-engines-2-6 branch and to HEAD, then close this bug.
OK, commited now.