After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 318095 - Compilation fixes
Compilation fixes
Status: RESOLVED FIXED
Product: gnome-utils
Classification: Deprecated
Component: general
2.12.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-utils Maintainers
gnome-utils Maintainers
: 324552 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-10-06 09:33 UTC by Stanislav Brabec
Modified: 2006-08-07 21:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gnome-utils-printf.patch (389 bytes, patch)
2005-10-06 09:43 UTC, Stanislav Brabec 		none Details | Review
gnome-utils-decl.patch (687 bytes, patch)
2005-10-06 09:46 UTC, Stanislav Brabec 		committed Details | Review
gnome-utils-include.patch (1.14 KB, patch)
2005-10-06 09:47 UTC, Stanislav Brabec 		committed Details | Review
screen-shot-error-dlg.diff (1.78 KB, patch)
2005-10-06 09:51 UTC, Stanislav Brabec 		none Details | Review
gnome-utils-logview.diff (507 bytes, patch)
2005-10-06 09:52 UTC, Stanislav Brabec 		committed Details | Review
gnome-utils-strict-aliasing.patch (3.45 KB, patch)
2005-10-06 14:13 UTC, Stanislav Brabec 		none Details | Review
updated patch (5.60 KB, patch)
2006-08-07 13:39 UTC, Kjartan Maraas 		none Details | Review

Description Stanislav Brabec 2005-10-06 09:33:48 UTC 
Attached patches fixes fome compilation warnings. Used for version 2.12.0.
Comment 1 Stanislav Brabec 2005-10-06 09:43:56 UTC 
Created attachment 53097 [details] [review]
gnome-utils-printf.patch

Missing argument to g_snprintf.
Comment 2 Stanislav Brabec 2005-10-06 09:46:05 UTC 
Created attachment 53098 [details] [review]
gnome-utils-decl.patch

Fix of missing includes.
Comment 3 Stanislav Brabec 2005-10-06 09:47:20 UTC 
Created attachment 53099 [details] [review]
gnome-utils-include.patch

Another fix for missing includes.
Comment 4 Stanislav Brabec 2005-10-06 09:51:00 UTC 
Created attachment 53100 [details] [review]
screen-shot-error-dlg.diff

Report about insufficient permissions.
Author: Shakti Prasad.
https://bugzilla.novell.com/show_bug.cgi?id=72379
Comment 5 Stanislav Brabec 2005-10-06 09:52:58 UTC 
Created attachment 53101 [details] [review]
gnome-utils-logview.diff

Prevent gcc cast warning.
Comment 6 Vincent Noel 2005-10-06 14:08:36 UTC 
The first attachment (missing argument) was already fixed a few days ago by
Rodrigo Moya. I committed patches #2, #3 and #5. I'd rather wait for approval
from jrb before committing patch #4 (gnome-screenshot).
Thanks a lot for all your work !
Comment 7 Stanislav Brabec 2005-10-06 14:13:31 UTC 
Created attachment 53115 [details] [review]
gnome-utils-strict-aliasing.patch

I have an another patch, which prevents "breaks strict aliasing rules" warnings
(which can cause miscompilation) but causes "passing argument ... from
incompatible pointer type" warnings. You may not want to submit it.
Comment 8 Kjartan Maraas 2006-08-07 13:16:37 UTC 
Looks like the last patch here is for 2.14.x? Is that right? At least only the part for gnome-screenshot applies here against HEAD.
Comment 9 Kjartan Maraas 2006-08-07 13:37:30 UTC 
*** Bug 324552 has been marked as a duplicate of this bug. ***
Comment 10 Kjartan Maraas 2006-08-07 13:39:17 UTC 
Created attachment 70387 [details] [review]
updated patch

I added some more compiler warning fixes. This patch contains the strict-aliasing warning fix from above that still applies to HEAD.
Comment 11 Emmanuele Bassi (:ebassi) 2006-08-07 21:17:45 UTC 
Fixed in HEAD and in 2.15.91.

Thanks to Stanislav and to Kjartan.