After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 316469 - Incorrect bounds check in hangul-fc.c
Incorrect bounds check in hangul-fc.c
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: hangul
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Changwoo Ryu
pango-maint
Depends on:
Blocks:
 
 
Reported: 2005-09-16 12:56 UTC by Owen Taylor
Modified: 2005-11-23 15:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Owen Taylor 2005-09-16 12:56:32 UTC 
The bounds check in hangul_engine_shape() needs to make sure
there are 3 free spaces in the jamos[] array because it might
write three elements there. But it only checks that there is
1 free space. (if (n_jamos == max_jamos)).

It should check if (n_jamos > max_jamos - 3).

Reported by Steve Grubb.
Comment 1 Behdad Esfahbod 2005-11-23 15:33:20 UTC 
2005-11-23  Behdad Esfahbod  <behdad@gnome.org>

        * modules/hangul/hangul-fc.c (hangul_engine_shape): Fix incorrect
        bounds check. (#316469, Steve Grubb)  Moreover, increase max_jamos
        eight at a time instead of three.