After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 316395 - Quick Mask button and dockable titles don't show shortcut in tooltip
Quick Mask button and dockable titles don't show shortcut in tooltip
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: User Interface
2.2.x
Other All
: Normal enhancement
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2005-09-15 14:29 UTC by Lox2Eagle
Modified: 2008-01-15 13:00 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Lox2Eagle 2005-09-15 14:29:24 UTC
The tool tip at mouseover over the Quick Mask button doesn't show the Shortcut.
This also applies to dialogs which have a shortcut assigned, e.g. the layers'
dialog.
It only reads 'Toggle Quick Mask' or 'Layers' or else. It should read 'Toggle
Quick Mask  Shift+Q' and 'Layers  Ctrl+L' as the tips in the tool box and menu
entries do.

Other information:
Comment 1 Sven Neumann 2005-09-15 16:13:26 UTC
We have a "Layers" button? Where's that?
Comment 2 weskaggs 2005-09-15 21:27:43 UTC
I think the bug reporter is referring to the tab that indicates the Layers
dialog in a dock -- it has a tooltip saying "Layers".
Comment 3 Michael Natterer 2005-09-15 21:46:51 UTC
No matter what the "Layers" button is, this sounds like a very useful
idea. I'm about to write a utility function that provides this functionality
for any widget/action pair, not only for toolbox buttons.
Comment 4 Michael Natterer 2005-09-16 00:48:21 UTC
This should be done generically in gimp_action_set_proxy(), but
that needs some more thinking...

2005-09-16  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpwidgets-utils.[ch] (gimp_widget_set_accel_help):
	mis-named and mis-placed function that sets a widget's tooltip to
	the action's tooltip plus the action's keyboard shortcut.

	* app/widgets/gimptoolbox.c: at least the code is not here any
	more.

	* app/actions/tools-actions.c: use tool_info->help, not ->blurb
	as the action's tooltip so the above works.
Comment 5 Michael Natterer 2005-10-30 18:42:38 UTC
Fixed in CVS for the two places mentioned. Closing as FIXED even though
there are probably more places which need this.

2005-10-30  Michael Natterer  <mitch@gimp.org>

	Fixed bug #316395:

	* app/actions/dialogs-actions.c (dialogs_dockable_actions)
	* app/actions/quick-mask-actions.c (quick_mask_toggle_actions):
	added tooltips to action entries.

	* app/display/gimpdisplayshell.c (gimp_display_shell_new): use
	gimp_widget_set_accel_help() to set the tooltip so it contains
	the accelerator.

	* app/dialogs/dialogs-constructors.c (dialogs_dockable_constructor):
	attach the dialog's identifier to the dockable widget (hack).

	* app/widgets/gimpdockbook.c (gimp_dockbook_get_tab_widget): use
	the attached identifier to find the action for this dockable in
	the dock's UI manager (HACK HACK). Use the found action to set
	a tooltip with accelerator.

	* app/widgets/gimpwidgets-utils.c (gimp_widget_set_accel_help):
	fixed bug in fallback code what should never be used.