After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 315001 - error: structure has no member named `close'
error: structure has no member named `close'
Status: RESOLVED FIXED
Product: gnome-vfs
Classification: Deprecated
Component: Module: smb
2.12.x
Other All
: Urgent critical
: ---
Assigned To: gnome-vfs maintainers
gnome-vfs maintainers
: 315136 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-09-01 05:28 UTC by Robert Ford
Modified: 2005-10-05 08:49 UTC
See Also:
GNOME target: 2.12.x
GNOME version: 2.11/2.12

Attachments
samba 3.0.20+ patch (2.07 KB, patch)
2005-09-02 11:30 UTC, Edward Hervey 		none Details | Review

Description Robert Ford 2005-09-01 05:28:38 UTC 
Version details: gnome-vfs-2.11.92
Distribution/Version: archlinux current

im using the current garnome-hackers to build gnome. my system is an up to date
Arch Linux box. when compiling gnome-vfs-2.11.92 i came across this error, 
smb-method.c: In function `do_close':  smb-method.c:1489: error: structure has
no member named `close'. the samba version i have is 3.0.20. when looking at the
samba header file libsmbclient.h, the closest thing i saw to `do_close' or
`close' was `close_fn'. i replaced both with `close_fn' and continued to compile
and install.
Comment 1 Edward Hervey 2005-09-02 11:29:00 UTC 
I made a patch to fix this problem.
Comment 2 Edward Hervey 2005-09-02 11:30:23 UTC 
Created attachment 51703 [details] [review]
samba 3.0.20+ patch

patch to gracefully handle the change of naming of the close function in
samba's context structure
Comment 3 Edward Hervey 2005-09-03 10:53:30 UTC 
*** Bug 315136 has been marked as a duplicate of this bug. ***
Comment 4 Robert Ford 2005-09-06 04:37:36 UTC 
i have tried this patch on gnome-vfs-2.12.0 in garnome and it works :)

thanks!
Comment 5 Christian Kirbach 2005-09-14 08:16:24 UTC 
adding build keyword.
Comment 6 Christian Neumair 2005-09-15 00:18:00 UTC 
Updating bug information, milestoning for next GNOME 2.12 release.
Comment 7 Daniel Llano 2005-09-17 16:07:55 UTC 
Why did upstream change the name of the function?
Maybe the name change should be reverted upstream.
Comment 8 Trevor Davenport 2005-09-28 23:27:53 UTC 
2.12.1 is due on the coming monday (Oct. 3rd).  It would be really good to get 
this in.  What's currently blocking it?  I seriously doubt that samba is going 
to change their structure....if it was changed it meant that they felt it 
should be changed.
Comment 9 Alexander Larsson 2005-10-05 08:49:47 UTC 
I commited the patch, and will release 2.12.1.1 with it.