GNOME Bugzilla – Bug 314370
plugin should only handle embedded media
Last modified: 2014-04-30 11:22:13 UTC
Please describe the problem: The Totem plugin correctly handles embedded media objects, but also becomes the default viewer for all the media types it supports. So when you click on a video file, expecting a prompt to download or play (in the normal totem player), the plugin takes over the entire browser display and plays the video. Most users will expect file links to download or play in non-plugin totem. Bastien asked me to file this to remind him to fix the issue. :-) (I love totem.) Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
I think it should be enough to not create the plugin when the mode is NP_FULL in the NP_New function, but I'm not quite sure what kind of error we're supposed to push back, or whether we can avoid the browser calling this function at all in case of mode != NP_EMBED.
The exact error code doesn't matter, gecko just checks for != NPERR_NO_ERROR. However returning an error doesn't seem to work here, it still does not pass the URL to the ext handler.
The upstream BZ is at: https://bugzilla.mozilla.org/show_bug.cgi?id=306867
By chance I've come across this pref: plugin.disable_full_page_plugin_for_types [http://lxr.mozilla.org/seamonkey/source/modules/plugin/base/src/nsPluginHostImpl.cpp#3729]; this may do what we want? However it's not clear how to do set that pref from the plugin and have it apply, since the plugin will already be loaded when we get there afaict.
*** Bug 354952 has been marked as a duplicate of this bug. ***
*** Bug 370619 has been marked as a duplicate of this bug. ***
How about we simply launch totem ourself in ::Init, and then return an error code so the plugin gets aborted?
(In reply to comment #7) > How about we simply launch totem ourself in ::Init, and then return an error > code so the plugin gets aborted? That would be a good thing to do until the Mozilla bug is fixed. Problem is that we'd like to have this to popup a dialogue asking whether to save it (bug 300691), or launch Totem. Any other ways to do that? Force Mozilla opening the stream with a bogus mime-type?
I think in this case, saving could be done in totem itself (bug 350261) after it's launched.
Ubuntu bug about that: https://launchpad.net/products/totem/+bug/72032
*** Bug 443502 has been marked as a duplicate of this bug. ***
This still isn't fixed! I have ubuntu 8.10 This very annoying bug.
(In reply to comment #12) > This still isn't fixed! That would be because it's still a bug in Mozilla. Read the bug before commenting about something we already knew.
I did read the mozilla bug. Anyway last activity on it goes back to 2007. This bug, is another thing, I can live with, but this is annoying.
This bug is directly linked to the mozilla bug. Unless Mozilla fix their browser, we can't fix our usage of their APIs.
Fine, lets bug them to fix this in this case...... :-)
See also https://bugs.webkit.org/show_bug.cgi?id=37278 for WebKit and https://wiki.mozilla.org/Talk:Plugins:PlatformIndependentNPAPI for the discussion about the Pepper extensions
The browser plugin has been removed from Totem. See this post for more details: http://www.hadess.net/2014/04/good-bye-totem-browser-plugin.html