GNOME Bugzilla – Bug 313674
Width of image information side pane
Last modified: 2005-10-28 02:50:46 UTC
The default width of the image information pane makes it occupy more than 1/3 of the window meaning less space for the image and much empty space in the side pane (at least when only the File tab is available). Since the primary thing you want to do with EOG is view images... well, this is no good. :) I understand that one want's all information in the side pane displayed without the need of a horizontal scroll bar but it should be possible to measure the width needed and set the width of the pane to only that.
Created attachment 50819 [details] Screenshot showing the side pane occyping more than 1/3 of the window.
If measuring the space needed is a complicated exercise, perhaps setting it to something smaller by default (but still enough for most cases... 1/4?) and remembering where the user puts it is enough?
Thanks for the report. Bug #315189 was just Fixed in CVS HEAD, thus fixing your problems.
Yes, it fixes the problem "takes up 1/3 of the width" but now the width of the information pane is to small. Only the "Attribute" column is visible. Otherwise it works correctly. At least that's what I think. That is, there's no empty space in the "image area" because the image has been made smaller to make the information pane fit in the window. (Btw, the patch hasn't hit anoncvs yet so I hope I didn't miss anything by making the one line modification myself...)
*** Bug 317678 has been marked as a duplicate of this bug. ***
Created attachment 53933 [details] [review] Suggested patch Patch against eog 2.12.1. Make image information side pane non-scrolled, and make the side pane not shrinkable smaller than its minimum allocation. Also, set the initial geometry after the image list is set up. (This makes geometry calculation more accurate). Result is that when eog starts the image is (if possible) displayed at 100% with the image information side pane at minimum allocation (column headers fully visible) and no gaps anywhere.
Forget that, it doesn't work (fails with very long file names). Seeing as the widths of the two sides of the vpane can take any value, perhaps just set the size request on info_view to some arbitrary width (the width of some arbitrary string)?
The only thing you need to fix here is the initial side pane width that must have column headers fully visible. Then, the user can resize it as (s)he wants.
Created attachment 53962 [details] [review] Revised patch This patch sets the size request of the info view pane to 3/2 the width of the requisition of the file info treeview (when the file info treeview is empty, so the file name does not affect this). I set it to 3/2 the width because the width requisiton of the file info treeview is enough to show the column headers (obviously!) but chops off most file names. Also, in eog_info_view_file_show_data() (and the same for the exif view) I set an idle handler to autosize the columns. It appears if this is not done the columns will not be autosized, so the scrollbar fails to appear even if needed.
The patch is OK though the autosize calls are not necessary here. The scrollbar works nice when needed. Applied without the idle calls, thanks!