GNOME Bugzilla – Bug 313212
Resizing of the window due to sidebar hiding/showing is wrong
Last modified: 2005-12-18 13:28:58 UTC
When you show the sidebar, totem is supposed to make itself wider, this doesn't work to good as you can see here: http://users.skynet.be/bk333867/desktop.ogg I'm using 1.1.4.
It seems like you forgot to apply this patch: Index: backend/video-utils.c =================================================================== RCS file: /cvs/gnome/totem/src/backend/video-utils.c,v retrieving revision 1.25 diff -u -r1.25 video-utils.c --- backend/video-utils.c 27 May 2005 16:18:52 -0000 1.25 +++ backend/video-utils.c 9 Aug 2005 15:53:57 -0000 @@ -288,6 +288,7 @@ gulong sig_id; } TotemPrefSize; +#if 0 static gboolean cb_unset_size (gpointer data) { @@ -297,6 +298,7 @@ return FALSE; } +#endif static void cb_set_preferred_size (GtkWidget *widget, GtkRequisition *req, @@ -309,7 +311,9 @@ g_signal_handler_disconnect (widget, size->sig_id); g_free (size); +#if 0 g_idle_add (cb_unset_size, widget); +#endif } void When I apply that part also, it works as it should.
*** Bug 315071 has been marked as a duplicate of this bug. ***
Confirming this on 1.2.0. What is the progress with this one? Is the patch being applied?
*** Bug 316566 has been marked as a duplicate of this bug. ***
*** Bug 314605 has been marked as a duplicate of this bug. ***
Another thing that was pointed out in bug 314605 is that toggling the controls (pressing h) in a large window resizes it in many different and weird ways.
ping
Created attachment 54005 [details] [review] one-liner patch to partially fix resizing issue. It seems that the sidebar's height was being subtracted from the window when the width should have been. This mostly fixes the behavior described in bug #315071. If the window's height is greater than its width, the window would become progressively smaller by increments of (y - x) each time the button was toggled, or vise verse. But if the sidebar is not visible when totem is started, the first time the user clicks the "> Sidebar" button, totem->sidebar->allocation.width is 1, so the window is only widened 1 pixel the first time the sidebar is shown. I've tried to find the most appropriate place to fix this, but I haven't been able to. Just as an experiment I put this: if (totem->sidebar->allocation.width == 1) totem->sidebar->allocation.width = (totem->win->allocation.width / 2); into on_sidebar_button_toggled (), and that helps, but this is not the right way to do it, and is not the correct initial width of the sidebar.
Should be fixed in CVS. Let us know if something's missing. *** This bug has been marked as a duplicate of 324346 ***