After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 313116 - Redefined LLONG_* in int.h
Redefined LLONG_* in int.h
Status: RESOLVED FIXED
Product: dasher
Classification: Applications
Component: macos
3.2.x
Other Mac OS
: Normal normal
: ---
Assigned To: Matthew Garrett
Matthew Garrett
Depends on:
Blocks:
 
 
Reported: 2005-08-10 13:09 UTC by Daniel Macks
Modified: 2006-01-27 22:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't redefine LLONG_MAX and LLONG_MIN (496 bytes, patch)
2005-09-16 15:41 UTC, Daniel Macks 		none Details | Review

Description Daniel Macks 2005-08-10 13:09:33 UTC 
Version details: 3.2.15
Distribution/Version: 10.3.9; XCode1.5 (gcc3.3)

Performing the standard './configure && make' gives warnings:

In file included from ../Common/Types/int32.h:14,
                 from DasherTypes.h:14,
                 from Alphabet.h:15,
                 from LanguageModel.h:20,
                 from PPMLanguageModel.h:14,
                 from PPMLanguageModel.cpp:10:
../Common/Types/int.h:36:1: warning: "LLONG_MAX" redefined
In file included from /usr/include/gcc/darwin/3.3/machine/limits.h:24,
                 from /usr/include/limits.h:63,
                 from /usr/include/gcc/darwin/3.3/c++/climits:49,
                 from /usr/include/gcc/darwin/3.3/c++/bits/stl_algobase.h:66,
                 from /usr/include/gcc/darwin/3.3/c++/vector:67,
                 from LanguageModel.h:17,
                 from PPMLanguageModel.h:14,
                 from PPMLanguageModel.cpp:10:
/usr/include/ppc/limits.h:80:1: warning: this is the location of the previous
definition

In file included from ../Common/Types/int32.h:14,
                 from DasherTypes.h:14,
                 from Alphabet.h:15,
                 from LanguageModel.h:20,
                 from PPMLanguageModel.h:14,
                 from PPMLanguageModel.cpp:10:
../Common/Types/int.h:37:1: warning: "LLONG_MIN" redefined
In file included from /usr/include/gcc/darwin/3.3/machine/limits.h:24,
                 from /usr/include/limits.h:63,
                 from /usr/include/gcc/darwin/3.3/c++/climits:49,
                 from /usr/include/gcc/darwin/3.3/c++/bits/stl_algobase.h:66,
                 from /usr/include/gcc/darwin/3.3/c++/vector:67,
                 from LanguageModel.h:17,
                 from PPMLanguageModel.h:14,
                 from PPMLanguageModel.cpp:10:
/usr/include/ppc/limits.h:81:1: warning: this is the location of the previous
definition

Why is dasher defining these itself? Looking at int.h:
  #ifdef _MSC_VER
    #ifndef LLONG_MAX
      #define LLONG_MAX 9223372036854775807
      #define LLONG_MIN (-LLONG_MAX - 1)
    #endif
  #else
    #define LLONG_MAX 9223372036854775807LL
    #define LLONG_MIN (-LLONG_MAX - 1LL)
  #endif

Why aren't these definitions wrapped in #ifndef in the #else block like they are
in the #if block?
Comment 1 Daniel Macks 2005-09-16 15:41:04 UTC 
Created attachment 52317 [details] [review]
Don't redefine LLONG_MAX and LLONG_MIN
Comment 2 Daniel Macks 2005-10-20 04:18:19 UTC 
Still broken in the dasher-3.2.18 release and also in CVS HEAD as of int.h
revision 1.6 (for which a patch is attached).
Comment 3 Behdad Esfahbod 2006-01-27 22:00:58 UTC 
Thanks.

2006-01-27  Behdad Esfahbod  <behdad@gnome.org>

        * Src/Common/Types/int.h: Do not redefine LLONG_*. (bug #313116)