After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 312906 - Don't show contacts that are not subscribed
Don't show contacts that are not subscribed
Status: RESOLVED FIXED
Product: gossip
Classification: Deprecated
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Gossip Maintainers
Gossip Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-08-08 15:56 UTC by Richard Hult
Modified: 2005-09-24 12:24 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Richard Hult 2005-08-08 15:56:00 UTC
There needs to be a check that contacts are actually in the roster before adding
them to the contact list. I have two contacts that are not in my roster that
somehow sends presence to me, and when they do, they are added to my contact list.
Comment 1 Martyn Russell 2005-08-11 16:50:05 UTC
So what should happen do you think?  Ignore them?  Put them in a *special* group?
Comment 2 Richard Hult 2005-08-11 16:55:58 UTC
I suggest not showing them at all, I don't have them in my roster so they should
never be visible to me.
Comment 3 Martyn Russell 2005-08-11 17:35:39 UTC
Mmm, I am thinking about special cases, like multiple resources showing in the
roster when they are not actually on your roster might be a problem there (since
you don't usually have yourself on your own roster).

There may be other instances too I haven't thought of.

I am not sure it is a good or bad idea to be honest.
Comment 4 Richard Hult 2005-08-11 17:47:31 UTC
It's just a bug, it's not a design issue... 

This is what happens, say that someone called Foo for some reason sends me
presence, maybe I'm in his list, or the rosters are out of sync or something. 

When I start gossip, I don't have Foo in my list, since when the roster is
received from the server, he's not in it. Then Foo for some reason sends a
presence message, the contact list happily puts it in there. So I won't have
that person in my list until the first time he has sent a presence message. Even
if he is onlike for three days before, I won't see him until he's changed his
presence.

When trying to remove the contact, (right click, remove), sure he goes away. But
only until the next time he changes presence, pop, he's back. Clearly a bug :)

I don't know why you'd want yourself in the list, I certainly don't want that
when I'm online with several resources. But that could be special-cased if there
are any reasons why that would be a good idea.
Comment 5 Martyn Russell 2005-08-12 08:29:32 UTC
OK you got my vote, :)
I will see what I can do. 
Comment 6 Mikael Hallendal 2005-08-12 08:46:48 UTC
Yes, this is most likely a simple bug to fix and explains why I thought I
couldn't "remove a contact" the other day :)
Comment 7 Martyn Russell 2005-08-12 11:45:43 UTC
I have committed something that works OK.  

It will not show people NOT in your roster and it will not show other connected
resources using the same account.

Should we be showing other resources on the roster?
Comment 8 Martyn Russell 2005-09-24 12:24:14 UTC
Closing this bug, since it has been fixed, no resources, group chat rooms or
unknown contacts have turned up on my roster.