GNOME Bugzilla – Bug 312121
[modplug] crashes on query before song fully loaded
Last modified: 2005-07-31 20:22:41 UTC
rhythmbox CVS HEAD now queries gstreamer to get position information (it previously used a GTimer) and this causes crashes when switching to a file handled by the modplug element. gst_modplug_src_query() assumes that modplug->mSoundFile has been set up, but if the element is queried before that has happened, the pointer will be NULL.
Created attachment 50008 [details] [review] simple fix
Committed, thanks! 2005-07-31 Jonathan Matthew <jonathan at kaolin dot hn dot org> Reviewed by: Tim-Philipp Muller * gst/modplug/gstmodplug.cc: Don't crash if a query comes in and we're not set up yet (fixes #312121). Cheers -Tim