After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 312121 - [modplug] crashes on query before song fully loaded
[modplug] crashes on query before song fully loaded
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.8.x
Other Linux
: Normal normal
: 0.8.11
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-07-31 07:49 UTC by Jonathan Matthew
Modified: 2005-07-31 20:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
simple fix (525 bytes, patch)
2005-07-31 07:51 UTC, Jonathan Matthew 		committed Details | Review

Description Jonathan Matthew 2005-07-31 07:49:18 UTC 
rhythmbox CVS HEAD now queries gstreamer to get position information (it
previously used a GTimer) and this causes crashes when switching to a file
handled by the modplug element.

gst_modplug_src_query() assumes that modplug->mSoundFile has been set up, but if
the element is queried before that has happened, the pointer will be NULL.
Comment 1 Jonathan Matthew 2005-07-31 07:51:00 UTC 
Created attachment 50008 [details] [review]
simple fix
Comment 2 Tim-Philipp Müller 2005-07-31 20:22:41 UTC 
Committed, thanks!

2005-07-31  Jonathan Matthew  <jonathan at kaolin dot hn dot org>

        Reviewed by: Tim-Philipp Muller

        * gst/modplug/gstmodplug.cc:
          Don't crash if a query comes in and we're not set
          up yet (fixes #312121).

 Cheers
  -Tim